Skip to content

add pkgconfig to homebrew install instruction #1936

Merged
merged 1 commit into from Apr 24, 2013

3 participants

@minrk
minrk commented Apr 23, 2013

build will not find freetype headers without it.

Alternate fix would be to search for freetype in the homebrew location (/usr/local/Cellar/freetype/VERSION/), or add the right location to the include path (/usr/local/include/freetype2).

Min RK add pkgconfig to homebrew install instruction
build will not find freetype headers without it.

Alternate fix would be to search for freetype in the homebrew location (`/usr/local/Cellar/freetype/VERSION/`), or add the right location to the include path (`/usr/local/include/freetype2`).
ac26781
@mdboom
Matplotlib Developers member
mdboom commented Apr 23, 2013

I'm wary of adding more hard-coded include paths to the system -- it can then be difficult for users to override that when they want to, say, use a locally built copy of freetype.

We could also display a more prominent message when pkg-config can't be found...

@minrk
minrk commented Apr 23, 2013

You use freetype-config to discover the freetype version, but you don't use it to generate the compile flags, so that's another option. Following the current README.osx will result in a successful "you have freetype 2.4.11", but the compilation will actually fail. freetype-config --libs and freetype-config --cflags should give the relevant info.

@pelson
Matplotlib Developers member
pelson commented Apr 24, 2013

Alternate fix would be to search for freetype in the homebrew location

Do we need an alternative fix? It sounds to me like adding pgkconfig to the install list is a good idea...

👍

@mdboom
Matplotlib Developers member
mdboom commented Apr 24, 2013

@minrk, @pelson: I agree that adding pkgconfig to the install list is a good idea in any event, though I also like the suggestion of trying to use freetype-config in addition to pkg-config (I hadn't thought of that, and I think that's a good suggestion). I'll work the latter up as a separate PR, and we can go ahead and merge this one.

@pelson pelson merged commit d431c2e into matplotlib:master Apr 24, 2013

1 check passed

Details default The Travis build passed
@minrk minrk deleted the minrk:macpkgconfig branch Apr 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.