in #1917 @nellev requested I import mplDeprecation directly from cbook. On further investigation I found that none of the current code did that.
This PR changes the import scheme to import directly from cbook everywhere.
Removed the import from cbook into the matplotlib name space in __init__
and changed all cases of
from matplotlib import MatplotlibDeprecationWarning as mplDeprecation
from cbook import mplDeprecation
Thanks for doing this work.
You should explicitely import cbook: either use from .cbook import blah or from matplotlib.cbook import blah.
I personnally prefer the first version, but matplotlib's codebase uses the latter (and it is the recommanded way of importing a intra package module).
from .cbook import blah
from matplotlib.cbook import blah
tweaked intra-package imports from cbook
Should lines like
iterable = cbook.iterable
is_string_like = cbook.is_string_like
is_sequence_of_strings = cbook.is_sequence_of_strings
(from axes.py) be changed to from matplotlib.cbook import blah ?
I think it would be cleaner, but I think this is a question of personal taste so I'll leave it up to you.
My inclination is to not change code that works, so I will leave it ;)