Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix bug in SpanSelector, introduced in commit #dd325759 #1982

Merged
merged 1 commit into from May 7, 2013

Conversation

Projects
None yet
3 participants
Owner

efiring commented May 7, 2013

The useblit attribute was being set after calling new_axes,
but new_axes needs that attribute. By setting useblit before
calling new_axes, we set it based on the initial canvas; even
though new_axes might change to a different canvas, we assume
it will be the same type of canvas (same backend), so its
supports_blit attribute will not change.

Fix bug in SpanSelector, introduced in commit #dd325759
The useblit attribute was being set after calling new_axes,
but new_axes needs that attribute.  By setting useblit before
calling new_axes, we set it based on the initial canvas; even
though new_axes might change to a different canvas, we assume
it will be the same type of canvas (same backend), so its
supports_blit attribute will not change.

pelson added a commit that referenced this pull request May 7, 2013

Merge pull request #1982 from efiring/SpanSelector_blit_bug
Fix bug in SpanSelector, introduced in commit dd32575

@pelson pelson merged commit 6131cf7 into matplotlib:master May 7, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Owner

mdboom commented May 7, 2013

@efiring: Thanks for fixing.

@efiring efiring deleted the efiring:SpanSelector_blit_bug branch May 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment