Setting dashes to (0,0) results in infinite loop for agg backends #1999

Merged
merged 1 commit into from May 14, 2013

3 participants

@rephorm

Other backends may also be affected. I have not tested exhaustively.

It would be good to check in GraphicsContextBase.set_dashes that dash_list is not all 0's. Some backends (cairo and gdk) override set_dashes, so those may need to be modified as well.

@mdboom mdboom was assigned May 13, 2013
@mdboom
Matplotlib Developers member

@rephorm: Can you please confirm that the attached patch resolves your problem?

@pelson
Matplotlib Developers member

👍 - this is good to merge.

@mdboom mdboom merged commit 616efcf into matplotlib:v1.2.x May 14, 2013

1 check passed

Details default The Travis CI build passed
@mdboom mdboom deleted the mdboom:dashes-infinite-loop branch Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment