Fixed hatch clipping. #2001

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

pelson commented May 14, 2013

No description provided.

Member

pelson commented May 14, 2013

Replaces #1898

Owner

mdboom commented May 14, 2013

👍 Seems like a pretty straightforward fix. Can you rebase this against v1.2.x, as I believe the bug exists there as well?

Member

pelson commented May 14, 2013

I've just done this locally, but the test results change (because of the color handling added recently on master).

For example with v1.2.x:

The svg rendering of one of the images in this PR looks like:

clip_path_clipping_svg

On this basis, I'm not sure its worth the extra overhead of putting it against v1.2.x.

Thoughts?

Owner

mdboom commented May 14, 2013

We can put different test images on each branch. I think better that than to have hatches continue to be broken. I'd like to put out a rock-solid 1.2.2 around the same time as 1.3.0...

pelson referenced this pull request May 14, 2013

Merged

Fixed hatch clipping. #2003

Member

pelson commented May 14, 2013

I'd like to put out a rock-solid 1.2.2 around the same time as 1.3.0...

I can't refuse a reasonable request 😄 - #2003

pelson closed this May 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment