Fixed hatch clipping. #2003

Merged
merged 3 commits into from May 15, 2013

Conversation

Projects
None yet
2 participants
Member

pelson commented May 14, 2013

Replaces #2001

pelson referenced this pull request May 14, 2013

Closed

Fixed hatch clipping. #2001

Owner

mdboom commented May 14, 2013

Looks good. I'll merge once Travis has had a chance to do its thing.

@mdboom mdboom commented on the diff May 15, 2013

lib/matplotlib/tests/test_artist.py
points = [(0.5,0.5), (1.5,0.5)]
assert np.all(path.contains_points(points) == [True, False])
+@image_comparison(baseline_images=["clip_path_clipping"], remove_text=True)
+def test_clipping():
+ exterior = mpath.Path.unit_rectangle()
@mdboom

mdboom May 15, 2013

Owner

After #2010 is merged, this can just be:

exterior = mpath.Path.unit_rectangle().deepcopy()

We should probably merge #2010 first, make that update here, and then merge this.

@pelson

pelson May 15, 2013

Member

This is against v1.2.x where #2010 is against master. I think it needs to be the other way around...

@mdboom

mdboom May 15, 2013

Owner

Indeed. So we can merge this, merge #2010, merge 1.2.x over to master, and then make my suggested change as part of that. (It doesn't really matter, but that feels like the path of least resistance...)

Member

pelson commented May 15, 2013

@mdboom - I don't think there is anything left for me to do in this PR. Is it good for merge?

@mdboom mdboom added a commit that referenced this pull request May 15, 2013

@mdboom mdboom Merge pull request #2003 from pelson/hatch_clipping_v1.2.x
Fixed hatch clipping.
a54e8b3

@mdboom mdboom merged commit a54e8b3 into matplotlib:v1.2.x May 15, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment