Skip to content
This repository

Fixed hatch clipping. #2003

Merged
merged 3 commits into from 11 months ago

2 participants

Phil Elson Michael Droettboom
Phil Elson
Collaborator
pelson commented May 14, 2013

Replaces #2001

Phil Elson pelson referenced this pull request May 14, 2013
Closed

Fixed hatch clipping. #2001

Michael Droettboom
Owner
mdboom commented May 14, 2013

Looks good. I'll merge once Travis has had a chance to do its thing.

Michael Droettboom mdboom commented on the diff May 15, 2013
lib/matplotlib/tests/test_artist.py
((62 lines not shown))
100 101
     points = [(0.5,0.5), (1.5,0.5)]
101 102
 
102 103
     assert np.all(path.contains_points(points) == [True, False])
103 104
 
104 105
 
  106
+@image_comparison(baseline_images=["clip_path_clipping"], remove_text=True)
  107
+def test_clipping():
  108
+    exterior = mpath.Path.unit_rectangle()
3
Michael Droettboom Owner
mdboom added a note May 15, 2013

After #2010 is merged, this can just be:

exterior = mpath.Path.unit_rectangle().deepcopy()

We should probably merge #2010 first, make that update here, and then merge this.

Phil Elson Collaborator
pelson added a note May 15, 2013

This is against v1.2.x where #2010 is against master. I think it needs to be the other way around...

Michael Droettboom Owner
mdboom added a note May 15, 2013

Indeed. So we can merge this, merge #2010, merge 1.2.x over to master, and then make my suggested change as part of that. (It doesn't really matter, but that feels like the path of least resistance...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Phil Elson
Collaborator
pelson commented May 15, 2013

@mdboom - I don't think there is anything left for me to do in this PR. Is it good for merge?

Michael Droettboom mdboom merged commit a54e8b3 into from May 15, 2013
Michael Droettboom mdboom closed this May 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 3 unique commits by 2 authors.

May 14, 2013
Phil Elson Fixed hatch clipping. deb211f
Michael Droettboom Don't overwrite unit_circle vertices -- causes problems for many othe…
…r tests
c0e2e48
Phil Elson Merge pull request #6 from mdboom/hatch_clipping_v1.2.x
Don't overwrite unit_circle vertices in clipping test
ee9f02b
Something went wrong with that request. Please try again.