Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed hatch clipping. #2003

Merged
merged 3 commits into from

2 participants

Phil Elson Michael Droettboom
Phil Elson
Collaborator

Replaces #2001

Phil Elson pelson referenced this pull request
Closed

Fixed hatch clipping. #2001

Michael Droettboom
Owner

Looks good. I'll merge once Travis has had a chance to do its thing.

Michael Droettboom mdboom commented on the diff
lib/matplotlib/tests/test_artist.py
((62 lines not shown))
points = [(0.5,0.5), (1.5,0.5)]
assert np.all(path.contains_points(points) == [True, False])
+@image_comparison(baseline_images=["clip_path_clipping"], remove_text=True)
+def test_clipping():
+ exterior = mpath.Path.unit_rectangle()
Michael Droettboom Owner
mdboom added a note

After #2010 is merged, this can just be:

exterior = mpath.Path.unit_rectangle().deepcopy()

We should probably merge #2010 first, make that update here, and then merge this.

Phil Elson Collaborator
pelson added a note

This is against v1.2.x where #2010 is against master. I think it needs to be the other way around...

Michael Droettboom Owner
mdboom added a note

Indeed. So we can merge this, merge #2010, merge 1.2.x over to master, and then make my suggested change as part of that. (It doesn't really matter, but that feels like the path of least resistance...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Phil Elson
Collaborator

@mdboom - I don't think there is anything left for me to do in this PR. Is it good for merge?

Michael Droettboom mdboom merged commit a54e8b3 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 14, 2013
  1. Phil Elson

    Fixed hatch clipping.

    pelson authored
  2. Michael Droettboom
  3. Phil Elson

    Merge pull request #6 from mdboom/hatch_clipping_v1.2.x

    pelson authored
    Don't overwrite unit_circle vertices in clipping test
Something went wrong with that request. Please try again.