Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make wx and wxagg work with wx 2.9.x on Mac. #2004

Merged
merged 1 commit into from May 24, 2013

Conversation

Projects
None yet
2 participants
Owner

efiring commented May 14, 2013

This affects the wx* backends on OSX only. It removes Mac-specific
code that was letting the Frame manage the toolbar directly, without
using the Sizer. There was a comment saying that this was needed
for OSX 10.3. With wx 2.9.x, however, this method of handling
the toolbar does not work at all; no toolbar appears, and the
program can hang or otherwise behave erratically. The Sizer
method, however, works.

The big question is whether the Sizer method works on the Mac
with wx 2.8.x. If it does, then this can be merged.

Owner

mdboom commented May 20, 2013

As a data point, this works fine with wx 2.8.12 on my Linux box.

Any testers with wx 2.8 on their Mac? It seems harmless enough...

Owner

mdboom commented May 24, 2013

@efiring: I'm fine with merging this now and then hopefully using the release candidate as an excuse for more users to test this and find issue if any. So feel free to merge if you agree.

@efiring efiring Make wx and wxagg work with wx 2.9.x on Mac.
This affects the wx* backends on OSX only.  It removes Mac-specific
code that was letting the Frame manage the toolbar directly, without
using the Sizer.  There was a comment saying that this was needed
for OSX 10.3.  With wx 2.9.x, however, this method of handling
the toolbar does not work at all; no toolbar appears, and the
program can hang or otherwise behave erratically.  The Sizer
method, however, works.

The big question is whether the Sizer method works on the Mac
with wx 2.8.x.  If it does, then this can be merged.
65027cf
Owner

efiring commented May 24, 2013

@mdboom, I added a commit to delete a comment line, squashed, and force-pushed; but github does seem to be hung (checking for ability to merge), so I won't try to merge yet.

Owner

mdboom commented May 24, 2013

I saw something like that elsewhere a few minutes ago, but it did seem to eventually update after about 15 minutes. They must be live coding on the site again ;)

@efiring efiring added a commit that referenced this pull request May 24, 2013

@efiring efiring Merge pull request #2004 from efiring/EF_wx_cocoa
Make wx and wxagg work with wx 2.9.x on Mac.
05d38ff

@efiring efiring merged commit 05d38ff into matplotlib:v1.2.x May 24, 2013

1 check passed

default The Travis CI build passed
Details

@efiring efiring deleted the efiring:EF_wx_cocoa branch May 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment