backend_gtk: don't hide FileChooserDialog; closes #1530 #2056

Merged
merged 2 commits into from May 24, 2013

3 participants

@efiring
Matplotlib Developers member

Hiding the FileChooserDialog was pointless, because a
new one is created each time the Save Figure button is
clicked in the Toolbar. Hiding seems to have prevented
the widget from being destroyed based on refcount, and this
led to heavy access to the recently-used.xbel file with
every subsequent keystroke.

efiring added some commits May 23, 2013
@efiring efiring backend_gtk: don't hide FileChooserDialog; closes #1530
Hiding the FileChooserDialog was pointless, because a
new one is created each time the Save Figure button is
clicked in the Toolbar.  Hiding seems to have prevented
the widget from being destroyed based on refcount, and this
led to heavy access to the recently-used.xbel file with
every subsequent keystroke.
bb6e6a9
@efiring efiring backend_gtk3: same fix as for backend_gtk, don't hide file chooser edf4a5a
@pelson
Matplotlib Developers member

👍 from me. I'm willing to merge this provided we can check that it hasn't had cross platform adverse affects in the release candidate. I propose we explicitly ask for release candidate testers to reply to the RC announcement with their OS, python version, numpy version and backends tested.

@mdboom
Matplotlib Developers member

Yeah -- I agree. Let's get this in the release candidate to give it lots of testing, and fix or revert as necessary before the final release.

@mdboom mdboom merged commit d6c6afd into matplotlib:v1.2.x May 24, 2013
@mdboom
Matplotlib Developers member

@efiring: Unfortunately, it now appears that the file save dialog never goes away. It saves the file, but the dialog remains open and responsive after clicking the Save button. This is on Fedora 18. Can you confirm on your system?

@efiring efiring deleted the efiring:gtk_filechooser_no_hide branch May 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment