pep8 fixes in animation.py #2057

Merged
merged 1 commit into from May 24, 2013

Conversation

Projects
None yet
2 participants
Owner

tacaswell commented May 24, 2013

mostly white space

one has_key -> in

Member

pelson commented May 24, 2013

L32 & L635 - are comments so it's fine to wrap over multiple lines.

Then you can take pleasure in making the matplotlib.tests.test_coding_standards fail and remove the appropriate line 😉.

Owner

tacaswell commented May 24, 2013

I had my pep8 checker being a bit too strict, oh well.

That was kinda fun.

The first build failure was matplotlib.tests.test_bbox_tight.test_bbox_inches_tight_suptile_legend.test again on 2.6 and the second one is a pip install issue on 3.2

Member

pelson commented May 24, 2013

This is 👍 @tacaswell. I think we may as well squash this commit and then I'll merge.

FWIW, I had a bit of fun this morning removing lots of files 😄 : https://github.com/matplotlib/matplotlib/pull/2059/files#diff-11

Owner

tacaswell commented May 24, 2013

What is the best way to squash the commit? I have actually never done that before.

Member

pelson commented May 24, 2013

The best article I've seen: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

in summary:

git rebase -i HEAD~3

Owner

tacaswell commented May 24, 2013

squashed (and passes all the tests this time!)

pelson added a commit that referenced this pull request May 24, 2013

@pelson pelson merged commit 2cc7e21 into matplotlib:master May 24, 2013

1 check passed

default The Travis CI build passed
Details

@tacaswell tacaswell deleted the tacaswell:animation_pep8 branch May 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment