Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix tox.ini #2060

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

tkf commented May 24, 2013

This PR fixes tox.ini. I also suggest to use tox in Travis CI, to prevent from breaking it.

@pelson pelson and 1 other commented on an outdated diff May 24, 2013

# The number of processes is hardcoded, because using too many causes the
# Travis VM to run out of memory (since so many copies of inkscape and
# ghostscript are running at the same time).
- echo Testing using 8 processes
- - python ../matplotlib/tests.py -sv --processes=8 --process-timeout=300
+ - tox -- --processes=8 --process-timeout=300
@pelson

pelson May 24, 2013

Member

We've lost an -sv here.

@tkf

tkf May 24, 2013

Contributor

Fixed.

Owner

mdboom commented May 24, 2013

Looks good. I'd like to hold off on merging this until post 1.3.0rc, since now's probably not a good time to mess with a known-working CI setup.

mdboom added a commit to mdboom/matplotlib that referenced this pull request May 28, 2013

mdboom added a commit to mdboom/matplotlib that referenced this pull request May 29, 2013

mdboom added a commit to mdboom/matplotlib that referenced this pull request May 29, 2013

mdboom added a commit to mdboom/matplotlib that referenced this pull request May 29, 2013

Member

dmcdougall commented Jun 23, 2013

This needs a rebase before merging. It looks like that tight_bbox test failure is not indicative or problems here, nonetheless a rebase should trigger a re-test anyway.

@tkf Would you be able to do that?

Contributor

tkf commented Jun 23, 2013

@dmcdougall OK. I'll rebase.

Contributor

tkf commented Jun 24, 2013

I rebased. Travis CI works except for Python 3.3. I don't know why it failed.

Owner

mdboom commented Jun 24, 2013

Yes -- the 3.3 failure is odd. The output seems to just suddenly stop...

Member

dmcdougall commented Jul 1, 2013

I reran py33 and I have problems with distribute. I then remembered this branch was made before the new distribute patch was merged.

@tkf Can you rebase this again so I can rerun the py33 travis job?

Member

dmcdougall commented Jul 6, 2013

I fetched your branch to do some testing myself. I just noticed that each of the test runs is not respecting the correct environment. Notice that python --version is returning 2.7.3 regardless of which py{26,27,32,33} environment is used.

@tkf Do you know how to make Travis respect the correct tox environment?

Member

dmcdougall commented Jul 6, 2013

Oh it's only using python 2.7 to pip install tox. Disregard my previous comment.

Member

dmcdougall commented Jul 6, 2013

Ok, it looks like tox is using and old version of distribute. Can anyone with actual tox experience confirm/deny this?

Contributor

tkf commented Jul 6, 2013

@dmcdougall You can use this option to use distribute instead of setuptools: http://tox.readthedocs.org/en/latest/config.html#confval-distribute=True|False

Owner

tacaswell commented Nov 26, 2013

@tkf Is this still a live PR? If so, it needs a re-base.

Owner

tacaswell commented Aug 18, 2014

Closing due to inactivity and the fact that we have striped tox out for just about every where else.

@tacaswell tacaswell closed this Aug 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment