Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

mlab.FIFOBuffer: remove fossil line referring to nonexistent method #2065

Merged
merged 1 commit into from May 28, 2013

Conversation

Projects
None yet
3 participants
Owner

efiring commented May 25, 2013

Evidently no one has been using the method in which the offending line occurred; the bug dates back to 2009.

Member

pelson commented May 28, 2013

Evidently no one has been using the method in which the offending line occurred

Should we deprecate FIFOBuffer? It is not used in any of the examples, and not tested.

Member

pelson commented May 28, 2013

For the bug fix. 👍

Owner

mdboom commented May 28, 2013

Yeah -- I'm +1 on marking this as deprecated now, removing later.

@mdboom mdboom added a commit that referenced this pull request May 28, 2013

@mdboom mdboom Merge pull request #2065 from efiring/FIFOBuffer_bug
mlab.FIFOBuffer: remove fossil line referring to nonexistent method
7f0c0eb

@mdboom mdboom merged commit 7f0c0eb into matplotlib:v1.2.x May 28, 2013

1 check passed

default The Travis CI build passed
Details

@efiring efiring deleted the efiring:FIFOBuffer_bug branch May 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment