Ignore transOffset if no offsets passed to Collection #21550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
added
the
Release critical
This fixes a regression from matplotlib#20717 in networkx (Fixes matplotlib#21517), but we'll go forward with the change in a later release to give them time to fix it.
QuLogic
force-pushed
the
fix-collection-offsets
branch
from
a6548ae
to
27ab206
Compare
timhoffm
approved these changes
Nov 6, 2021
dstansby
approved these changes
Nov 6, 2021
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Nov 18, 2021
This also reverts matplotlib#21550, which was not intended to be part of 3.6.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Nov 18, 2021
This also reverts matplotlib#21550, which was not intended to be part of 3.6.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This fixes a regression from #20717 in networkx (Fixes #21517), but we'll go forward with the change in a later release to give them time to fix it.
Since this will be reverted for 3.6, this is targeting v3.5.x directly.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).