Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latex as the program name for kpsewhich #22349

Merged
merged 1 commit into from Jan 30, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 29, 2022

PR Summary

If tex is not installed, then setting the program name to it will fail to find the 'program' in the current directory, and then be unable to find any TeX files.

Setting it to latex should be okay, since that's what we're running to create the .dvi in the first place.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.5.2 milestone Jan 29, 2022
@QuLogic QuLogic requested a review from anntzer January 29, 2022 05:30
If `tex` is not installed, then setting the program name to it will fail
to find the 'program' in the current directory, and then be unable to
find any TeX files.

Setting it to `latex` should be okay, since that's what we're running
to create the `.dvi` in the first place.
@QuLogic QuLogic changed the title Use luatex as the program name for kpsewhich Use latex as the program name for kpsewhich Jan 29, 2022
@QuLogic
Copy link
Member Author

QuLogic commented Jan 29, 2022

I also just noticed that checkdep_usetex checks for tex, but I don't see us running tex, only latex; should that be switched too?

@anntzer
Copy link
Contributor

anntzer commented Jan 29, 2022

I don't think I have seen a case where latex is installed and not tex, but sure, this seems reasonable.

Also agreed that checkdep_usetex should probably check latex indeed.

@timhoffm timhoffm merged commit 6eba0af into matplotlib:main Jan 30, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 30, 2022
timhoffm added a commit that referenced this pull request Jan 30, 2022
…349-on-v3.5.x

Backport PR #22349 on branch v3.5.x (Use latex as the program name for kpsewhich)
@QuLogic QuLogic deleted the luatex-kpsewhich branch January 31, 2022 22:54
@QuLogic
Copy link
Member Author

QuLogic commented Jan 31, 2022

I don't think I have seen a case where latex is installed and not tex, but sure, this seems reasonable.

It is the case on my (new-ish) laptop, as I did not install all of texllive, or even a specific scheme, just the few .sty, etc. files I knew were needed for Matplotlib tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants