Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Axes __repr__ to 3D #23452

Merged
merged 2 commits into from Jul 21, 2022
Merged

Conversation

scottshambaugh
Copy link
Contributor

@scottshambaugh scottshambaugh commented Jul 19, 2022

PR Summary

Axes3D did not have the zlabel included in its repr, this adds that. We could cut down on code duplication by modifying the base axes string, but that seems a little sketchy.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Contributor

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. A test would be nice and useful. Especially if one is trying to merge things later.

@anntzer
Copy link
Contributor

anntzer commented Jul 20, 2022

I would suggest just writing the base class __repr__ as something like (untested)

        for name, axis in self._axis_map:
            if axis.get_label():
                fields += [f"{name}label={axis.get_label().get_text()!r}"]

@scottshambaugh
Copy link
Contributor Author

@anntzer that's way nicer, changed

@scottshambaugh scottshambaugh changed the title Add zlabel to axes3d __repr__ Generalize Axes __repr__ to 3D Jul 20, 2022
@scottshambaugh
Copy link
Contributor Author

Tests added

@QuLogic QuLogic added this to the v3.6.0 milestone Jul 21, 2022
@QuLogic QuLogic merged commit 8afcbc2 into matplotlib:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants