Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mathtext support for \middle and correct rendering of \| #23685

Closed
wants to merge 2 commits into from

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Aug 20, 2022

PR Summary

Closes #23212
Closes #23250

\mid is added as a valid delimiter.

The text image is not ideal because of #23250 (comment), which is also why the whats-new-note uses cm as fontfamily. If that is fixed before this goes into a release, one should probably remove that from the note. Check the note for the "proper" behavior.

(I'll open a new issue for #23250 (comment) if this is merged.)

If in doubt about it actually is working, here is what happend replacing | or mid with )

image

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus force-pushed the mathtextmiddle branch 2 times, most recently from 9d11e50 to a25d3c7 Compare August 20, 2022 18:34
@oscargus oscargus changed the title Add mathtext support for \middle Add mathtext support for \middle and correct rendering of \| Aug 20, 2022
@oscargus oscargus changed the title Add mathtext support for \middle and correct rendering of \| Add mathtext support for \middle and correct rendering of \| Aug 20, 2022
@oscargus
Copy link
Contributor Author

Closing this and may restart the middle-part later.

@oscargus oscargus closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect mathtext rendering of r"$\|$" with default (dejavu) math fontfamily Support \middle
1 participant