Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Enable building Python 3.13 wheels for nightlies #28293

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 24, 2024

PR summary

And also bump cibuildwheel, replacing #28265, which dependabot messed up.

PR checklist

@QuLogic
Copy link
Member Author

QuLogic commented Jun 25, 2024

It looks like Pillow will have a release on or about July 1 which will have 3.13 wheels, so I'll wait till about then before looking at this again.

@zerothi
Copy link
Contributor

zerothi commented Jul 5, 2024

This is somewhat related to this PR, when 3.13 hits the release, which versions of matplotlib will be supported under 3.13? How far will you go back and create wheels? (do you have a plan)

Thanks for this package!

@QuLogic
Copy link
Member Author

QuLogic commented Jul 6, 2024

It will be in whatever the next release is when 3.13 is ABI stable.

@QuLogic QuLogic force-pushed the py313 branch 4 times, most recently from 31b62a0 to 3a03904 Compare July 6, 2024 09:38
@QuLogic
Copy link
Member Author

QuLogic commented Jul 24, 2024

Pillow now has free-threading wheels on the nightly channel, so I've enabled testing as well (except for Windows, since NumPy doesn't have those wheels yet.) Of course, the testing is just an import check, and our extensions don't claim free-threading support, so it's not much of a test.

@QuLogic
Copy link
Member Author

QuLogic commented Jul 24, 2024

Looks like we'll need to skip cp313t-manylinux_aarch64 as there are no Pillow wheels there yet.

@tacaswell
Copy link
Member

I'm going to go ahead and merge this.

@tacaswell tacaswell merged commit 725ee99 into matplotlib:main Jul 25, 2024
42 of 44 checks passed
@QuLogic QuLogic deleted the py313 branch July 25, 2024 19:43
@EwoutH
Copy link

EwoutH commented Aug 8, 2024

Python 3.13rc1 is out now, which is ABI stable with future 3.13 releases. the latest cibuildwheel (2.20) uses it and builds 3.13 wheels by default.

What would be the fastest way to get 3.13 wheels on PyPI? Would a backport to the 3.9 branch be possible?

Edit: A PR to update cibuildwheel was already opened:

@tacaswell
Copy link
Member

We will backport that cibuildwheel update to 3.9.x branch and the next release will have the additional wheels. In general we do not go back and rebuild wheels for already released versions.

@EwoutH
Copy link

EwoutH commented Aug 8, 2024

Awesome that it can be backported, looking forward to matplotlib 3.9.2 with Python 3.13 wheels!

QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Aug 9, 2024
… and bump cibuildwheel

This is the commit message #1:

> Merge pull request matplotlib#28293 from QuLogic/py313
>
> BLD: Enable building Python 3.13 wheels for nightlies

(cherry picked from commit 725ee99)

This is the commit message #2:

> Merge pull request matplotlib#28668 from matplotlib/dependabot/github_actions/actions-167bd8b160
>
> Bump the actions group with 2 updates

(cherry picked from commit fd42e7d)
ksunden added a commit that referenced this pull request Aug 9, 2024
…3.9.x

Backport PR #28293 and #28668: Enable 3.13 wheels and bump cibuildwheel
@zerothi zerothi mentioned this pull request Aug 12, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build CI: Run cibuildwheel Run wheel building tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants