Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Marker/scatter reconciliation #400

Merged
merged 9 commits into from
+2,665 −1,996

3 participants

@mdboom
Owner

The set of available Line2D markers and scatter markers has always been slightly different. Some features (such as mathtext markers) were only available in one place and not the other. This refactors everything into a new markers.py module which is used from everywhere else to keep the functionality consistent and equally capable everywhere.

This seems to pass all regression tests and doesn't change any relevant examples, but it's pretty core functionality, so care should be taken it doesn't break anything.

@mdboom
Owner

Addresses bugs #350, #125

CHANGELOG
@@ -1,3 +1,12 @@
+2001-07-15 The set of markers available in the plot() and scatter()
@efiring Owner
efiring added a note

2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@efiring efiring commented on the diff
src/_backend_agg.cpp
((6 lines not shown))
path.total_vertices(),
- 1.0);
+ 0.0);
@efiring Owner
efiring added a note

Mike, I'm curious: what is the effect of the two changes here?

@mdboom Owner
mdboom added a note

This makes the markers more accurately align over the line drawn underneath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mdboom mdboom merged commit fafc0cf into from
@mdboom

The change to degrees was not intentional. @jdh2358, @efiring: What do you guys think? Do you think the angle of the scatter marker should stay in radians (as it always was)?

Collaborator

Personally, in general I would be in favour of using degrees throughout. There are a couple of reasons for this:

  • Easier to work with for less mathematically minded
  • Quicker to type for the more mathematically minded. i.e. np.pi/2 vs 90
  • Degrees suffers less with floating point precision issues (this is a bit of a moot point)
@mdboom mdboom deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 14, 2011
  1. @mdboom

    First step in marker refactoring. Create new marker class and reimple…

    mdboom authored
    …ment Line2D-based markers in terms of it.
  2. @mdboom
Commits on Jul 15, 2011
  1. @mdboom

    Make scatter use the new marker class. Add a "scatter_symbol" example…

    mdboom authored
    …. Make legend support the new kind of scatter.
  2. @mdboom
  3. @mdboom
  4. @mdboom

    Clarify CHANGELOG comment.

    mdboom authored
  5. @mdboom
  6. @mdboom

    Fix some regression tests.

    mdboom authored
Commits on Jul 18, 2011
  1. @mdboom
Something went wrong with that request. Please try again.