/matplotlib

Label outer offset text #4446

Merged
merged 2 commits into from Mar 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
2 participants
@anntzer @tacaswell
@anntzer
Contributor

anntzer commented May 20, 2015

Partial fix for #4445: hide the offset text when using label outer. Also slightly saner(?) implementation of check_{shared,visible} in the tests.

tacaswell added the needs_review label May 20, 2015

@tacaswell
Owner

tacaswell commented May 21, 2015

Any guesses what is causing that failure? That is an unexpected one...

tacaswell added this to the next point release milestone May 21, 2015

@anntzer
Contributor

anntzer commented May 21, 2015

I have no idea. I am unable to run the entire test suite locally due to some (unrelated) LaTeX error but I did make sure that the tests I wrote pass...

@tacaswell tacaswell modified the milestone: proposed next point release, next point release Jun 17, 2015

@tacaswell
Owner

tacaswell commented Jun 17, 2015

Moved to 'proposed next point release' meaning that this will not be a blocker for the next point release, but will go in if it is ready, as this is failing the tests and has had no activity for a month.
@anntzer
Contributor

anntzer commented Jun 17, 2015

Can you try to reproduce the test failure locally? Here, for me, test_diff_cell_table passes fine, so I have no idea of what is happening.
@tacaswell
Owner

tacaswell commented Jun 18, 2015

I also can not reproduce this, kicked travis to restart.

tacaswell closed this Mar 22, 2016

tacaswell reopened this Mar 22, 2016

@tacaswell tacaswell added needs_review and removed needs_review labels Mar 22, 2016

@tacaswell
Owner

tacaswell commented Mar 22, 2016

It looks like the test_shared test is missing a @cleanup. My guess is that somehow the addition of the second figure in that test is what is causing trouble?

anntzer added some commits May 20, 2015

@anntzer anntzer Also hide offsetText when using label_outer. 
Partially fixes #4445.
 91b3019
@anntzer anntzer Saner(?) implementation of check_{shared,visible}. 
Also cleanup after the tests.

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
a97cb54
@anntzer
Contributor

anntzer commented Mar 22, 2016

Well, the tests seemed to be passing at least on 3.5, but adding an @clenaup can't hurt so I just amended the second commit.
@tacaswell
Owner

tacaswell commented Mar 22, 2016

The dispatching on the multiprocess may not be deterministic.
@anntzer
Contributor

anntzer commented Mar 22, 2016

Ouch!

@tacaswell tacaswell merged commit 448d9ed into matplotlib:master Mar 26, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Mar 26, 2016

anntzer deleted the anntzer:label_outer-offsetText branch May 11, 2016

anntzer referenced this pull request Jun 21, 2016

Merged

Hide "inner" {x,y}labels in label_outer too. #6619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment