Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
fix #4854: set default numpoints of legend entries to 1 #5131
Conversation
tacaswell
added the
needs_review
label
Sep 24, 2015
jenshnielsen
added the
default changes
label
Sep 24, 2015
|
The classic style should have numpoints=2, The idea of the classic style is to provide a style that exactly replicates how MPL looked before the default changes. |
|
Also apparently the test-images must be updated when the PR is ready. |
|
No the tests run with the classic style as default to avoid having to update all the test images. |
tacaswell
added this to the
next major release (2.0)
milestone
Sep 24, 2015
|
Please don't merge this until we have pushed the 1.5 development off the master branch. |
WeatherGod
added the
needs_revision
label
Sep 24, 2015
|
Hmmm, that is strange that only the legend_expand tests failed. Could that codepath be utilizing rcparams incorrectly? |
|
@gauteh Can you rebase? I believe something has corrected the failure on master. |
gauteh
added some commits
Sep 24, 2015
tacaswell
added a commit
that referenced
this pull request
Feb 8, 2016
|
|
tacaswell |
d3a9782
|
tacaswell
merged commit d3a9782
into matplotlib:master
Feb 8, 2016
tacaswell
removed needs_review needs_revision
labels
Feb 8, 2016
|
Backported as part of #5774. |
gauteh commentedSep 24, 2015
check #4854: set default numpoints to 1.
I am a bit unsure abouth wether classic.mplstyle should be changed.