AutoMinorLocator and and logarithmic axis #5267

Merged
merged 2 commits into from May 9, 2016

Conversation

Projects
None yet
3 participants
Contributor

cimarronm commented Oct 17, 2015

Adds logic to check the scale when generating the ticks for AutoMinorLocator rather than just assuming it is linear scale. Outputs a warning if scale is not linear with no minor ticks.

mdboom added the needs_review label Oct 17, 2015

Owner

mdboom commented Oct 19, 2015

Do we really want no ticks when on a non-linear scale, or just a warning.

Also, there may be other non-linear scales besides just log, some of which may be appropriate for this ticker. Maybe better to blacklist log than whitelist linear?

Contributor

cimarronm commented Oct 22, 2015

Makes sense, I'll change it to blacklist log rather than whitelist linear.

cimarronm added some commits Oct 17, 2015

@cimarronm cimarronm BUG: Check scale for AutoMinorLocator and throw a warning if not linear cb5042d
@cimarronm cimarronm Modified to blacklist log scale for AutoMinorLocator
19baac5

@tacaswell tacaswell merged commit 325205e into matplotlib:master May 9, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.282%
Details

tacaswell removed the needs_review label May 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment