/matplotlib

Fixed issue with `rasterized` not working for errorbar #5466

Merged
merged 1 commit into from Dec 31, 2015
+2 −2

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Duplicate
Projects
None yet
Milestone
  v1.5.1
5 participants
@orso82 @mdboom @tacaswell @WeatherGod @QuLogic
@orso82
Contributor

orso82 commented Nov 11, 2015

This pull request fixes the rasterized argument not being passed to the lines of the errorbar

tacaswell added the needs_review label Nov 11, 2015

mdboom added this to the Critical bugfix release (1.5.1) milestone Nov 12, 2015

@mdboom
Owner

mdboom commented Nov 12, 2015

It looks like this just needs to be cleaned up for PEP8 (too long lines), but otherwise, I'm 👍. We should also add a test. I don't think an image comparison test will pick this up (since the rasterized version should be close enough to a non-rasterized one). But you could create an errorbar with rasterized set to True and then just introspect that get_rasterized on the artists returns True.

@tacaswell tacaswell added needs_revision and removed needs_review labels Nov 24, 2015

@tacaswell
Owner

tacaswell commented Dec 21, 2015

@orso82 Any update on this?

tacaswell referenced this pull request Dec 31, 2015

Merged

Fix eb rasterize #5773

@WeatherGod WeatherGod merged commit 2b66c27 into matplotlib:master Dec 31, 2015
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

tacaswell removed the needs_revision label Dec 31, 2015

QuLogic added the Duplicate label Dec 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment