qt: raise each new window #5553

Merged
merged 1 commit into from Dec 14, 2015

Conversation

Projects
None yet
4 participants
Owner

efiring commented Nov 24, 2015

This is an attempt to make progress on #596 with a one-line change to the qt backend that adds a call to raise_(). It raises and grabs focus. I would prefer that it not grab focus, but at least on OSX I don't know how to avoid it. The present behavior on OSX is so annoying that I am willing to accept the focus grab. Contrary to what I thought, my test of the qt4 backend on Linux without this change shows that at least on my XFCE desktop, the window is already being raised, including the focus grab; so the changeset here is just making OSX behave like this Linux desktop.

I also tried the approach of using the WindowStaysOnTopHint, but the problem is that it really stays on top, and that's no good either.

@efiring efiring qt: raise each new window
9a0afe3
Owner

mdboom commented Nov 24, 2015

Is there an analogous solution for Qt4 (which is still fairly relevant given that's what Anaconda gives?)

Owner

efiring commented Nov 24, 2015

It should work for both. I only have qt4 on my machine, so that is all I have tested it with. Most of qt4 support is inherited from the backend_qt5 modules.

Owner

tacaswell commented Nov 24, 2015

The naming on the qt4/qt5 modules is a bit odd (sorry, that is my fault), but qt5 is the 'base' implementation and the qt4 implementations sub-classes from it and patches over the API changes (the rearrangement of Qt it self and the change in PyQt5 to use cooperative sub-classes).

@mdboom mdboom added a commit that referenced this pull request Dec 14, 2015

@mdboom mdboom Merge pull request #5553 from efiring/qtontop
qt: raise each new window
5904e2f

@mdboom mdboom merged commit 5904e2f into matplotlib:master Dec 14, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 67.385%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label Dec 14, 2015

@mdboom mdboom added a commit that referenced this pull request Dec 14, 2015

@mdboom mdboom Merge pull request #5553 from efiring/qtontop
qt: raise each new window
1c7fb5b
Owner

mdboom commented Dec 14, 2015

Backported to v2.0.x as 1c7fb5b

@tacaswell tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Dec 19, 2015

@mdboom @tacaswell mdboom + tacaswell Merge pull request #5553 from efiring/qtontop
qt: raise each new window
dee9757

efiring deleted the efiring:qtontop branch Jun 23, 2016

Member

QuLogic commented Oct 16, 2016

Backport to v2.x is actually via dee9757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment