Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Change `savefig.dpi` and `figure.dpi` defaults #5659
Conversation
mdboom
added this to the
next major release (2.0)
milestone
Dec 11, 2015
|
|
efiring
added a commit
that referenced
this pull request
Dec 13, 2015
|
|
efiring |
6333526
|
efiring
merged commit 6333526
into matplotlib:master
Dec 13, 2015
1 check passed
|
Cherry-picked to v2.0.x as a903315. @tacaswell, did I do that correctly? |
|
@efiring: We've been cherry-picking the merge commit (which in this case is 6333526) rather than the individual commits (in this case 016406a). I think you did the latter. It's not a huge difference, but it does keep a mention in the logs of which PR a feature came from for later reference if you do the former. It's also easier to merge a multi-commit PR that way. |
|
@mdboom, OK, that makes sense, thank you. That requires using the "-m parent" option to the "git cherry-pick" command, doesn't it? How does one know the parent number? |
|
It is always parent 1 because we are meeting things into master On Sun, Dec 13, 2015, 10:33 Eric Firing notifications@github.com wrote:
|
|
Travis is complaining about the original commit, but it seems unrelated to the actual file changes. Should I be worried?
|
|
Something seems to have gone wrong with that file, #5652 had the same issue. |
|
Hm, strange. It seems like only AppVeyor was run. |
three-comrades commentedDec 11, 2015
Change the default values for
savefig.dpiandfigure.dpias suggested in #305.