Low-hanging performance improvements #5664

mdboom · Dec 11, 2015

Instantiating Paths is expensive, but they aren't mutable, so just reuse
when possible.

WeakValueDictionaries are expensive to construct. We can fix that by
handling the weakrefs ourself.

And cbook.popall has no reason to exist. Maybe someone's using it and it should stay, but no one should be using it.

On my benchmark of:

plt.subplots(8, 8)
plt.savefig("test.png")

I get a speedup from 5.04s to 3.81s.

mdboom · Dec 22, 2015

I think this is finally ready-to-merge.

Does this need a check that v() returns an active ref?

I currently check on deserializing (__setstate__) where you have to deal with it. No real need to do it in both places unless we really care about the size of the serialization.

fair enough.

FWIW, there is a fast instantiation route for Paths: https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/path.py#L173.

mdboom added the needs_review label Dec 11, 2015

tacaswell added this to the proposed next point release (2.1) milestone Dec 22, 2015

tacaswell added a commit that referenced this pull request Dec 22, 2015

tacaswell Merge pull request #5664 from mdboom/performance
PRF: Low-hanging performance improvements
50ce5ff

tacaswell removed the needs_review label Dec 22, 2015

mdboom	`Fix pickling`	Some checks were not successful 1 failing and 1 successful checks continuous-integration/travis-ci/pr — The Travis CI build failed Details continuous-integration/appveyor/pr — AppVeyor build succeeded Details	`1299528`
mdboom	`Fix comment`	Some checks were not successful 1 failing, 1 pending, and 1 successful checks continuous-integration/travis-ci/pr — The Travis CI build failed Details coverage/coveralls — Coverage pending from Coveralls.io Details continuous-integration/appveyor/pr — AppVeyor build succeeded Details	`0364847`
mdboom	`Fix pickling`	Some checks were not successful 1 failing and 1 successful checks continuous-integration/travis-ci/pr — The Travis CI build failed Details continuous-integration/appveyor/pr — AppVeyor build succeeded Details	`49f77ad`
mdboom	`Fix pickle`	Some checks were not successful 1 failing, 1 pending, and 1 successful checks continuous-integration/travis-ci/pr — The Travis CI build failed Details coverage/coveralls — Coverage pending from Coveralls.io Details continuous-integration/appveyor/pr — AppVeyor build succeeded Details	`26d3e25`
mdboom	`Fix pickling`	Some checks were not successful 1 failing and 2 successful checks continuous-integration/travis-ci/pr — The Travis CI build failed Details continuous-integration/appveyor/pr — AppVeyor build succeeded Details coverage/coveralls — Coverage increased (+0.08%) to 68.322% Details	`5e1ee64`
mdboom	`PEP8`	All checks have passed 3 successful checks continuous-integration/appveyor/pr — AppVeyor build succeeded Details continuous-integration/travis-ci/pr — The Travis CI build passed Details coverage/coveralls — Coverage increased (+0.08%) to 68.321% Details	`8a69511`

@@ -109,14 +106,17 @@ def __str__(self):
          def __getstate__(self):
              d = self.__dict__.copy()
-    -        # turn the weakkey dictionary into a normal dictionary
-    -        d['_parents'] = dict(six.iteritems(self._parents))
+    +        # turn the dictionary with weak values into a normal dictionary
+    +        d['_parents'] = dict((k, v()) for (k, v) in

@@ -93,6 +93,8 @@
      (TICKLEFT, TICKRIGHT, TICKUP, TICKDOWN,
       CARETLEFT, CARETRIGHT, CARETUP, CARETDOWN) = list(xrange(8))
+    +_empty_path = Path(np.empty((0, 2)))

matplotlib/matplotlib

Low-hanging performance improvements #5664

mdboom commented Dec 11, 2015

mdboom added the needs_review label Dec 11, 2015

mdboom added some commits Dec 12, 2015

mdboom commented Dec 22, 2015

tacaswell commented on the diff Dec 22, 2015

tacaswell added this to the proposed next point release (2.1) milestone Dec 22, 2015

tacaswell added a commit that referenced this pull request Dec 22, 2015

tacaswell merged commit `50ce5ff` into matplotlib:master Dec 22, 2015
3 checks passed

3 checks passed

tacaswell removed the needs_review label Dec 22, 2015

pelson commented on the diff Jan 6, 2016

matplotlib/matplotlib

Join GitHub today

Low-hanging performance improvements #5664

Conversation

mdboom commented Dec 11, 2015

Some checks were not successful

mdboom added the needs_review label Dec 11, 2015

mdboom added some commits Dec 12, 2015

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

All checks have passed

mdboom commented Dec 22, 2015

tacaswell commented on the diff Dec 22, 2015

tacaswell Dec 22, 2015

mdboom Dec 22, 2015

tacaswell Dec 22, 2015

tacaswell added this to the proposed next point release (2.1) milestone Dec 22, 2015

tacaswell added a commit that referenced this pull request Dec 22, 2015

Hide details View details tacaswell merged commit 50ce5ff into matplotlib:master Dec 22, 2015 3 checks passed

3 checks passed

tacaswell removed the needs_review label Dec 22, 2015

pelson commented on the diff Jan 6, 2016

pelson Jan 6, 2016

tacaswell merged commit `50ce5ff` into matplotlib:master Dec 22, 2015
3 checks passed