Fix #5573: Use SVG in docs #5677

Merged
merged 2 commits into from Dec 16, 2015

Conversation

Projects
None yet
4 participants
Owner

mdboom commented Dec 14, 2015

This looks a lot better on hi-res displays, and I think will be a nice show-off for the style changes in 2.0.

I think what this PR needs is testing on various browsers and some manual looking for things where SVG breaks (though it all looks pretty good to me on spot-checking, and SVG is one of our better-tested backends).

@mdboom mdboom Fix #5573: Use SVG in docs
43c66e1

mdboom added this to the next major release (2.0) milestone Dec 14, 2015

mdboom added the needs_review label Dec 14, 2015

Owner

jenshnielsen commented Dec 15, 2015

Something goes wrong in the format parsing

/home/travis/build/matplotlib/matplotlib/doc/mpl_examples/pylab_examples/xcorr_demo.py:11: 
WARNING: image file not readable: api/../build/plot_directive/mpl_examples/pylab_examples/xcorr_demo.p
@mdboom mdboom Fix format parsing
f6b15c5

@tacaswell tacaswell added a commit that referenced this pull request Dec 16, 2015

@tacaswell tacaswell Merge pull request #5677 from mdboom/docs-svg
Fix #5573: Use SVG in docs
838fa1f

@tacaswell tacaswell merged commit 838fa1f into matplotlib:master Dec 16, 2015

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 68.319%
Details

tacaswell removed the needs_review label Dec 16, 2015

Owner

tacaswell commented Dec 16, 2015

Merging this so that we can see what the built docs look like at http://matplotlib.org/devdocs

We should hold of back porting this until we are sure we are happy with it.

Owner

jenshnielsen commented Dec 16, 2015

For this to take effect on the devdocs we probably need to change either https://github.com/matplotlib/matplotlib/blob/master/.travis.yml#L110 to not build small or
change small to include svg

@jenshnielsen jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this pull request Dec 31, 2015

@jenshnielsen jenshnielsen Also catch RuntimeErrors
Borrowed from #5677 which is not backported to 2.x
16698e8

@jenshnielsen jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this pull request Jan 1, 2016

@jenshnielsen jenshnielsen Also catch RuntimeErrors
Borrowed from #5677 which is not backported to 2.x
3be205b
Member

QuLogic commented Oct 16, 2016 edited

This was reverted (see #6835.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment