Include outward ticks in bounding box #5683

mdboom · Dec 15, 2015

Replaces #5502.

mdboom · Dec 15, 2015

This needs a test specifically of tight layout on outward ticks, but I thought I'd put this up for comment early anyway...

QuLogic · Dec 15, 2015

I think you meant this replaces #5502?

mdboom · Dec 15, 2015

I think you meant this replaces #5502?

Oops. You're right.

QuLogic · Dec 15, 2015

Well, I don't see anything particularly wrong with it, but are there no test images that use outward ticks? Or just none with a tight bounding box?

mdboom · Dec 16, 2015

A test has been added

Is this going to work for polar axes? I would also double-check that this doesn't utterly bork for axes3d (not that I'd expect it to work great there, just to not crash or something).

polar axes don't have ticks -- but it does appear that this needs to be updated so it's aware of when the ticks are present or not.

It doesn't seem to crash for axes3d, though as you say, it doesn't really do the right thin other than add a bit more space.

WeatherGod · Dec 16, 2015

image tests that have just been added are failing

WeatherGod · Dec 16, 2015

I don't think the test is really all that useful. tight_layout is for ensuring that subplots don't run into each other. So, a good test would be to have a grid of subplots, perhaps each with different tick directions?

mdboom · Dec 17, 2015

@WeatherGod: I've updated the test as you helpfully suggested.

bit of a bike shed, better to do this with a dictionary?

Sure.

should this be max(self.majorTicks[0].get_tick_padding(), self.minorTicks[0].get_tick_padding())) ?

Never underestimate pathological users....

That's a good point.

Another point: are we always guaranteed at least one tick?

On Thu, Dec 17, 2015 at 11:59 AM, Michael Droettboom <
notifications@github.com> wrote:

In lib/matplotlib/axis.py
#5683 (comment):
@@ -1097,6 +1108,9 @@ def get_tightbbox(self, renderer):
else:
return None
def get_tick_padding(self):
   return self.majorTicks[0].get_tick_padding()
That's a good point.

—
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/5683/files#r47930730.

mdboom · Dec 17, 2015

I've addressed @tacaswell's comments, and added minor ticks to the test to catch the pathological case he mentions.

mdboom · Dec 17, 2015

Also updated to handle the case where there are no ticks, as suggested by @WeatherGod

tacaswell · Dec 19, 2015

backported as 2a6bb26

QuLogic · Oct 16, 2016

Backport to v2.x was actually via 8ac5b4b.

mdboom added the needs_review label Dec 15, 2015

mdboom added this to the next major release (2.0) milestone Dec 15, 2015

mdboom Address comments in PR 97b3985

tacaswell added a commit that referenced this pull request Dec 19, 2015

tacaswell Merge pull request #5683 from mdboom/tight-ticks
Include outward ticks in bounding box
08fc864

tacaswell removed the needs_review label Dec 19, 2015

tacaswell added a commit that referenced this pull request Dec 19, 2015

tacaswell Merge pull request #5683 from mdboom/tight-ticks
Include outward ticks in bounding box
2a6bb26

tacaswell added a commit that referenced this pull request Dec 19, 2015

tacaswell Merge pull request #5683 from mdboom/tight-ticks
Include outward ticks in bounding box
8ac5b4b

This was referenced Jan 18, 2016

Closed

tight_layout doesn't leave enough space between outwards ticks and axes title #5868

Closed

plt.tight_layout(pad=0) cuts away outer ticks #5281

		mdboom	`Include outward ticks in bounding box`		All checks have passed 2 successful checks continuous-integration/appveyor/pr — AppVeyor build succeeded Details continuous-integration/travis-ci/pr — The Travis CI build passed Details	`46ae4d9`
		mdboom	`Correct comment`		All checks have passed 3 successful checks continuous-integration/appveyor/pr — AppVeyor build succeeded Details continuous-integration/travis-ci/pr — The Travis CI build passed Details coverage/coveralls — Coverage increased (+0.008%) to 68.327% Details	`62804e8`

@@ -567,7 +567,11 @@ def get_window_extent(self, *args, **kwargs):
              get the axes bounding box in display space; *args* and
              *kwargs* are empty
              """
-    -        return self.bbox
+    +        bbox = self.bbox
+    +        x_pad = self.xaxis.get_tick_padding()
+    +        y_pad = self.yaxis.get_tick_padding()
+    +        return mtransforms.Bbox([[bbox.x0 - x_pad, bbox.y0 - y_pad],
+    +                                 [bbox.x1 + x_pad, bbox.y1 + y_pad]])

@@ -169,6 +169,21 @@ def apply_tickdir(self, tickdir):
              """
              pass
+    +    def get_tickdir(self):
+    +        return self._tickdir
+    +
+    +    def get_tick_padding(self):
+    +        """
+    +        Get the length of the tick outside of the axes.
+    +        """
+    +        tickdir = self._tickdir
+    +        if tickdir == 'in':

		mdboom	`Add test`			`0bf73c1`
		mdboom	`Handle case where there are no ticks`		All checks have passed 3 successful checks continuous-integration/appveyor/pr — AppVeyor build succeeded Details continuous-integration/travis-ci/pr — The Travis CI build passed Details coverage/coveralls — Coverage increased (+0.02%) to 68.303% Details	`0a4b52e`

matplotlib/matplotlib

Include outward ticks in bounding box #5683

mdboom commented Dec 15, 2015

mdboom added the needs_review label Dec 15, 2015

mdboom added some commits Dec 15, 2015

mdboom commented Dec 15, 2015

mdboom added this to the next major release (2.0) milestone Dec 15, 2015

QuLogic commented Dec 15, 2015

mdboom commented Dec 15, 2015

QuLogic commented Dec 15, 2015

mdboom commented Dec 16, 2015

WeatherGod commented on the diff Dec 16, 2015

WeatherGod commented Dec 16, 2015

WeatherGod commented Dec 16, 2015

mdboom commented Dec 17, 2015

tacaswell and 1 other commented on an outdated diff Dec 17, 2015

tacaswell and 2 others commented on an outdated diff Dec 17, 2015

mdboom commented Dec 17, 2015

mdboom commented Dec 17, 2015

mdboom added some commits Dec 16, 2015

tacaswell added a commit that referenced this pull request Dec 19, 2015

tacaswell merged commit `08fc864` into matplotlib:master Dec 19, 2015
3 checks passed

3 checks passed

tacaswell removed the needs_review label Dec 19, 2015

tacaswell commented Dec 19, 2015

tacaswell added a commit that referenced this pull request Dec 19, 2015

tacaswell added a commit that referenced this pull request Dec 19, 2015

This was referenced Jan 18, 2016

tight_layout doesn't leave enough space between outwards ticks and axes title #5868

plt.tight_layout(pad=0) cuts away outer ticks #5281

QuLogic commented Oct 16, 2016

matplotlib/matplotlib

Join GitHub today

Include outward ticks in bounding box #5683

Conversation

mdboom commented Dec 15, 2015

mdboom added the needs_review label Dec 15, 2015

mdboom added some commits Dec 15, 2015

All checks have passed

All checks have passed

mdboom commented Dec 15, 2015

mdboom added this to the next major release (2.0) milestone Dec 15, 2015

QuLogic commented Dec 15, 2015

mdboom commented Dec 15, 2015

QuLogic commented Dec 15, 2015

mdboom commented Dec 16, 2015

WeatherGod commented on the diff Dec 16, 2015

WeatherGod commented Dec 16, 2015

WeatherGod commented Dec 16, 2015

mdboom commented Dec 17, 2015

Show 2 comments Hide comments tacaswell and 1 other commented on an outdated diff Dec 17, 2015

Show 3 comments Hide comments tacaswell and 2 others commented on an outdated diff Dec 17, 2015

mdboom commented Dec 17, 2015

mdboom commented Dec 17, 2015

mdboom added some commits Dec 16, 2015

All checks have passed

tacaswell added a commit that referenced this pull request Dec 19, 2015

Hide details View details tacaswell merged commit 08fc864 into matplotlib:master Dec 19, 2015 3 checks passed

3 checks passed

tacaswell removed the needs_review label Dec 19, 2015

tacaswell commented Dec 19, 2015

tacaswell added a commit that referenced this pull request Dec 19, 2015

tacaswell added a commit that referenced this pull request Dec 19, 2015

This was referenced Jan 18, 2016

QuLogic commented Oct 16, 2016

tacaswell and 1 other commented on an outdated diff Dec 17, 2015

tacaswell and 2 others commented on an outdated diff Dec 17, 2015

tacaswell merged commit `08fc864` into matplotlib:master Dec 19, 2015
3 checks passed