/matplotlib

Update documentation of stem to mention StemContainer #5691

Merged
merged 1 commit into from Mar 7, 2017
+1 −1

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects

Done in Reviewing pull requests.

Milestone
  2.1 (next point r...
3 participants
@goretkin @tacaswell @QuLogic
@goretkin
Contributor

goretkin commented Dec 17, 2015

To be honest, I'm not sure this PR is a good idea, since StemContainer behaves like the tuple mentioned.
@goretkin goretkin Update documentation of stem 
changed here: d68662a

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 68.284%
Details
ba51fa0

@tacaswell tacaswell added needs_review Documentation labels Dec 17, 2015

tacaswell added this to the proposed next point release (2.1) milestone Dec 18, 2015

@tacaswell
Owner

tacaswell commented Dec 18, 2015

Because Container is a sub-class of tuple.

I am mostly 👍 on this.
@QuLogic
Member

QuLogic commented Feb 25, 2017

@tacaswell So should we just merge this then?

@tacaswell tacaswell merged commit 5faff6e into matplotlib:master Mar 7, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.284%
Details

QuLogic removed the needs_review label Mar 7, 2017

QuLogic changed the title from WIP: Update documentation of stem to mention StemContainer to Update documentation of stem to mention StemContainer Mar 7, 2017

QuLogic moved from Work in Progress to Done in Reviewing pull requests. Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment