/matplotlib

BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673 #5700

Merged
merged 2 commits into from Dec 20, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v1.5.1
3 participants
@efiring @tacaswell @QuLogic
@efiring
Owner

efiring commented Dec 20, 2015

No description provided.

@efiring efiring BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673

Some checks were not successful

1 failing, 1 pending, and 1 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage pending from Coveralls.io
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
b16caa1

efiring added the needs_review label Dec 20, 2015

@efiring efiring Update 2 baseline images. 
The change to contour_manual_colors_and_levels is clear: it is now
including ticks that should have been there all along.
The change to double_cbar is almost imperceptible, but I suspect it
is also the addition of a tick that was previously missing.

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-0.002%) to 68.319%
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
1616f67

@tacaswell tacaswell added a commit that referenced this pull request Dec 20, 2015

@tacaswell tacaswell Merge pull request #5700 from efiring/colorbar_tick_trim 
BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673
 497ffa8

@tacaswell tacaswell merged commit 497ffa8 into matplotlib:master Dec 20, 2015
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 68.319%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Dec 20, 2015

@tacaswell tacaswell added a commit that referenced this pull request Dec 20, 2015

@tacaswell tacaswell Merge pull request #5700 from efiring/colorbar_tick_trim 
BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673

used master branch pngs
 f19fea6
@tacaswell
Owner

tacaswell commented Dec 20, 2015

backported to 1.5.x as f19fea6

It looks like in 164222a these images were changed to include the regression. I had issues trying to get the pngs on this PR to show up as changed in the cherry-pick.

https://github.com/matplotlib/matplotlib/blob/v1.5.x/lib/matplotlib/tests/baseline_images/test_contour/contour_manual_colors_and_levels.png

https://github.com/matplotlib/matplotlib/blob/v1.5.x/lib/matplotlib/tests/baseline_images/test_colorbar/double_cbar.png

both look correct.

QuLogic added this to the Critical bugfix release (1.5.1) milestone Dec 21, 2015

@tacaswell tacaswell added a commit that referenced this pull request Dec 21, 2015

@tacaswell tacaswell Merge pull request #5700 from efiring/colorbar_tick_trim 
BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673
 4fd5f55
@tacaswell
Owner

tacaswell commented Dec 21, 2015

also had to be backported to 2.x which already had the code changes merged in to move the test image changes.

4fd5f55

efiring deleted the efiring:colorbar_tick_trim branch Jun 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment