Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Refresh pgf baseline images. #5727
Conversation
tacaswell
added the
needs_review
label
Dec 23, 2015
|
@pwuertz may want to double check these, but in principle it seems fine to me. |
|
We probably want to hold this up until #5724 is merged since that probably changes pgf_rcupdate2.pdf again |
jenshnielsen
added this to the
next major release (2.0)
milestone
Dec 23, 2015
|
This should probably be backported to 2.x? |
jenshnielsen
referenced
this pull request
Dec 23, 2015
Closed
[WIP] Run Travis on Ubuntu 14.04 #5730
|
maybe waiting on #5772 |
|
Looks reasonable, and reminds me to check the test results from time to time. Some small details might be worth checking out (not related to this PR). |
|
@pwuertz The tests should really be run on Travis. If I remember correctly the reason they are not is that the Travis images are based on Ubuntu 12.04 which ships a too old version of texlive (xetex). I tried switching to the new images in #5730 unfortunately that does not work with the Travis cache feature that we use. |
|
Yea, the issue was that the setup for running the PGF tests was too heavy / uncommon so we decided to exclude them from the default set of tests. I guess this was even before we had a CI system / Travis. Could be possible to include the tests in such a controlled environment, but I don't know about the cache feature you mentioned. |
|
The cache feature is not related to the pgf backend. It's there such that we don't have to build Numpy etc from scratch every time we run the tests. Unfortunatly it's not available on the Ubuntu 14.04 images. |
|
I tried installing the pgf and zetex packages on this Travis node type unfortunately now a different test is failing (test_pdflatex) I guess this is due to an out of date version of texlive |
|
I have installed the dependencies on Travis and refreshed all images. Lets hope that is enough to get the tests to pass. |
|
From looking at the tests on a Ubuntu 12.04 image the main reason for the needed tolerance seems to be the fonts selected. The 2 pdflatex test are different do to a different font whereas the xelatex one mainly seems to be due to different kerneling which may or may not be due to the font. |
|
Regenerated the images on top of the new master. Still need to fix the font selection. The links below show the changes since github still does not due rich diffs for pdfs
|
|
By installing cm-super I should have been able to lover the diffs for two more tests to zero. Unfortunatly cm-super is not currently allowed on Travis. I will take care of that. The final test still needs a diff of 4 to pass. From manual comparison it seems like it's only a text kerning issue but inspecting the pdf files seems to indicate that they are using different fonts.
|
This was referenced Feb 6, 2016
jenshnielsen
added some commits
Dec 22, 2015
|
This should finally be working. I have reduced all the tolerances to 0 apart from rc_update1 (see above) I have rebased the changed on top of the now merged style changes pr #5774 (the pgf tests do not use the classic style) It is useful to verify the changes by comparing the pdf links above but I think they make sense. |
tacaswell
closed this
Feb 15, 2016
tacaswell
reopened this
Feb 15, 2016
tacaswell
added needs_review and removed needs_review
labels
Feb 15, 2016
tacaswell
added a commit
that referenced
this pull request
Feb 16, 2016
|
|
tacaswell |
f19241d
|
tacaswell
merged commit f19241d
into matplotlib:master
Feb 16, 2016
tacaswell
removed the
needs_review
label
Feb 16, 2016
|
Should this be backported to 2.x? |
|
Yes I will do that as a pr |
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
Feb 16, 2016
|
|
tacaswell + jenshnielsen |
0187a78
|
jenshnielsen
referenced
this pull request
Feb 16, 2016
Merged
Backport Refresh pgf baseline images. #5727 #6008
jenshnielsen
deleted the
jenshnielsen:refreshpgfimages branch
Feb 16, 2016
QuLogic
added Testing backend/pgf
labels
Feb 16, 2016
jenshnielsen
added a commit
that referenced
this pull request
Feb 17, 2016
|
|
jenshnielsen |
3a5f06f
|
jenshnielsen commentedDec 23, 2015
These have changed due to the 2.x work on ticks and changes of dpi but was not caught since travis does not run the pgf tests. I think the changes are ok and makes sense