Refresh pgf baseline images. #5727

Merged
merged 7 commits into from Feb 16, 2016

Conversation

Projects
None yet
5 participants
Owner

jenshnielsen commented Dec 23, 2015

These have changed due to the 2.x work on ticks and changes of dpi but was not caught since travis does not run the pgf tests. I think the changes are ok and makes sense

Owner

mdboom commented Dec 23, 2015

@pwuertz may want to double check these, but in principle it seems fine to me.

Owner

jenshnielsen commented Dec 23, 2015

We probably want to hold this up until #5724 is merged since that probably changes pgf_rcupdate2.pdf again

jenshnielsen added this to the next major release (2.0) milestone Dec 23, 2015

Owner

jenshnielsen commented Dec 23, 2015

This should probably be backported to 2.x?

Owner

tacaswell commented Jan 3, 2016

maybe waiting on #5772

Contributor

pwuertz commented Jan 4, 2016

Looks reasonable, and reminds me to check the test results from time to time. Some small details might be worth checking out (not related to this PR).

Owner

jenshnielsen commented Jan 4, 2016

@pwuertz The tests should really be run on Travis. If I remember correctly the reason they are not is that the Travis images are based on Ubuntu 12.04 which ships a too old version of texlive (xetex). I tried switching to the new images in #5730 unfortunately that does not work with the Travis cache feature that we use.

Contributor

pwuertz commented Jan 4, 2016

Yea, the issue was that the setup for running the PGF tests was too heavy / uncommon so we decided to exclude them from the default set of tests. I guess this was even before we had a CI system / Travis. Could be possible to include the tests in such a controlled environment, but I don't know about the cache feature you mentioned.

Owner

jenshnielsen commented Jan 4, 2016

The cache feature is not related to the pgf backend. It's there such that we don't have to build Numpy etc from scratch every time we run the tests. Unfortunatly it's not available on the Ubuntu 14.04 images.

Owner

jenshnielsen commented Jan 4, 2016

I tried installing the pgf and zetex packages on this Travis node type unfortunately now a different test is failing (test_pdflatex) I guess this is due to an out of date version of texlive

Owner

jenshnielsen commented Jan 15, 2016

I have installed the dependencies on Travis and refreshed all images. Lets hope that is enough to get the tests to pass.

Owner

jenshnielsen commented Jan 15, 2016

This still needs to be hold of until #5724 and #5772 is merged to avoid regenerating the images multiple times

Owner

jenshnielsen commented Jan 16, 2016

From looking at the tests on a Ubuntu 12.04 image the main reason for the needed tolerance seems to be the fonts selected. The 2 pdflatex test are different do to a different font whereas the xelatex one mainly seems to be due to different kerneling which may or may not be due to the font.

Owner

jenshnielsen commented Feb 6, 2016

Regenerated the images on top of the new master. Still need to fix the font selection. The links below show the changes since github still does not due rich diffs for pdfs

Owner

jenshnielsen commented Feb 6, 2016

By installing cm-super I should have been able to lover the diffs for two more tests to zero. Unfortunatly cm-super is not currently allowed on Travis. I will take care of that.

The final test still needs a diff of 4 to pass. From manual comparison it seems like it's only a text kerning issue but inspecting the pdf files seems to indicate that they are using different fonts.

pdffonts pgf_rcupdate1.pdf 
name                                 type              emb sub uni object ID
------------------------------------ ----------------- --- --- --- ---------
UKIXHV+LMRoman10-Regular-Identity-H  CID Type 0C       yes yes yes      6  0
UDYZXV+LMSans17-Regular-Identity-H   CID Type 0C       yes yes yes      8  0
EGPOOW+CMSY10                        Type 1C           yes yes no       9  0
GOUKDS+CMMI12                        Type 1C           yes yes no      10  0
EQCFIK+CMR17                         Type 1C           yes yes no      11  0
ICUTZB+CMR12                         Type 1C           yes yes no      12  0
pdffonts expected_pgf_rcupdate1.pdf 
name                                 type              emb sub uni object ID
------------------------------------ ----------------- --- --- --- ---------
QXFOXX+LMSans17-Regular-Identity-H   CID Type 0C       yes yes yes      7  0
CHCLNW+CMSY10                        Type 1C           yes yes no       8  0
VLXDTR+CMMI12                        Type 1C           yes yes no       9  0
ZOZAKN+CMR17                         Type 1C           yes yes no      10  0
UQFOZG+CMR12                         Type 1C           yes yes no      11  0

jenshnielsen added some commits Dec 22, 2015

@jenshnielsen jenshnielsen Refresh pgf baseline images.
These have changed due to the 2.x work on ticks and changes of dpi but was not
caught since travis does not run the pgf tests
361b384
@jenshnielsen jenshnielsen Install pgf dependencies on travis 1fbedd6
@jenshnielsen jenshnielsen Lower test tolerance for pgf tests 21dc1a4
@jenshnielsen jenshnielsen Raise the already existing error with more information 66cecff
@jenshnielsen jenshnielsen backend_pgf parameterize tol and adjust to hopefully pass on travis bb99bf6
@jenshnielsen jenshnielsen Install cm-super fonts and lower tol of tests that should pass with t…
…he right fonts
c2eaecc
@jenshnielsen jenshnielsen Actually check of the requested tex system
e2c8154
Owner

jenshnielsen commented Feb 9, 2016

This should finally be working. I have reduced all the tolerances to 0 apart from rc_update1 (see above)

I have rebased the changed on top of the now merged style changes pr #5774 (the pgf tests do not use the classic style) It is useful to verify the changes by comparing the pdf links above but I think they make sense.

tacaswell closed this Feb 15, 2016

tacaswell reopened this Feb 15, 2016

@tacaswell tacaswell added needs_review and removed needs_review labels Feb 15, 2016

@tacaswell tacaswell added a commit that referenced this pull request Feb 16, 2016

@tacaswell tacaswell Merge pull request #5727 from jenshnielsen/refreshpgfimages
TST: Refresh pgf baseline images.
f19241d

@tacaswell tacaswell merged commit f19241d into matplotlib:master Feb 16, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Feb 16, 2016

Owner

tacaswell commented Feb 16, 2016

Should this be backported to 2.x?

Owner

jenshnielsen commented Feb 16, 2016

Yes I will do that as a pr

@jenshnielsen jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this pull request Feb 16, 2016

@tacaswell @jenshnielsen tacaswell + jenshnielsen Merge pull request #5727 from jenshnielsen/refreshpgfimages
TST: Refresh pgf baseline images.
0187a78

jenshnielsen deleted the jenshnielsen:refreshpgfimages branch Feb 16, 2016

@jenshnielsen jenshnielsen added a commit that referenced this pull request Feb 17, 2016

@jenshnielsen jenshnielsen Merge pull request #6008 from jenshnielsen/backport_pgf
Backport Refresh pgf baseline images. #5727
3a5f06f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment