Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Silence labeled data warning in tests #5739
+10
−6
Conversation
jenshnielsen
added some commits
Dec 24, 2015
tacaswell
added the
needs_review
label
Dec 24, 2015
|
I added another commit to fix a warning in the cycles test. The warnings.catch_warnings context manager does not actually catch the warning without a warnings filter. |
|
Silenced yet another warning by making sure a font file is closed |
tacaswell
added a commit
that referenced
this pull request
Dec 24, 2015
|
|
tacaswell |
a1e1fc2
|
tacaswell
merged commit a1e1fc2
into matplotlib:master
Dec 24, 2015
tacaswell
removed the
needs_review
label
Dec 24, 2015
|
how far back do we want to port this? |
|
I was inclined to not backport it apart from the improved warning message it really only touches test output but I am ok with backporting it to 2.x |
jenshnielsen
deleted the
jenshnielsen:labelformatwarning branch
Dec 24, 2015
|
sold on not backporting. |
QuLogic
added this to the
proposed next point release (2.1)
milestone
Dec 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jenshnielsen commentedDec 24, 2015
Continuing to fix various warnings in the test suite.
This suppresses a warning in the labeled data test and improves the error message a bit.