/matplotlib

Fix eb rasterize #5773

Merged
merged 2 commits into from Dec 31, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v1.5.1
3 participants
@tacaswell @WeatherGod @orso82
@tacaswell
Owner

tacaswell commented Dec 31, 2015

alternative to #5466

If travis passes I plan to self merge this

orso82 and others added some commits Nov 11, 2015

@orso82 orso82 Fixed issue with `rasterized` not working for errorbar
2b66c27
@tacaswell tacaswell PEP8: wrap line

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 68.502%
Details
0899658

tacaswell added this to the Critical bugfix release (1.5.1) milestone Dec 31, 2015

tacaswell added the needs_review label Dec 31, 2015

@WeatherGod WeatherGod commented on the diff Dec 31, 2015

View full changes
lib/matplotlib/axes/_axes.py
@@ -2873,7 +2873,8 @@ def xywhere(xs, ys, mask):
plot_kw['markeredgewidth'] = capthick
# For backwards-compat, allow explicit setting of
# 'mew' or 'markeredgewidth' to over-ride capthick.
- for key in ('markeredgewidth', 'mew', 'transform', 'alpha', 'zorder'):
+ for key in ('markeredgewidth', 'mew', 'transform', 'alpha',
+ 'zorder', 'rasterized'):
@WeatherGod

WeatherGod Dec 31, 2015

Member

you know... I only added this one tiny bit of logic back in the day for handling "mew" in case users already figured out how to adjust the cap thickness (it was never documented). I intended to deprecate that at some point, but forgot to do that. I didn't think it would ever be used for other things like this. Perhaps there are other keyword arguments that should be checked?

@tacaswell

tacaswell Dec 31, 2015

Owner

probably

@WeatherGod WeatherGod added a commit that referenced this pull request Dec 31, 2015

@WeatherGod WeatherGod Merge pull request #5773 from tacaswell/fix_eb_rasterize 
Fix eb rasterize
 0abca30

@WeatherGod WeatherGod merged commit 0abca30 into matplotlib:master Dec 31, 2015
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.502%
Details

tacaswell removed the needs_review label Dec 31, 2015

@WeatherGod
Member

WeatherGod commented Dec 31, 2015

heh, no worries. We will figure it out eventually!

tacaswell deleted the tacaswell:fix_eb_rasterize branch Dec 31, 2015

@WeatherGod WeatherGod added a commit that referenced this pull request Dec 31, 2015

@WeatherGod WeatherGod Merge pull request #5773 from tacaswell/fix_eb_rasterize 
Fix eb rasterize
 016ef98
@WeatherGod
Member

WeatherGod commented Dec 31, 2015

backported to v1.5.x as 016ef98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment