Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Index.html template. Only insert snippet if found #5789
Conversation
tacaswell
added the
needs_review
label
Jan 3, 2016
tacaswell
added a commit
that referenced
this pull request
Jan 3, 2016
|
|
tacaswell |
f6fca8a
|
tacaswell
merged commit f6fca8a
into matplotlib:master
Jan 3, 2016
tacaswell
removed the
needs_review
label
Jan 3, 2016
jenshnielsen
deleted the
jenshnielsen:indexfallback branch
Jan 3, 2016
QuLogic
added this to the
proposed next point release (2.1)
milestone
Jan 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jenshnielsen commentedJan 3, 2016
If you build a local copy of the documentation for preview such as
http://jenshnielsen.github.io/matplotlib/ the main
index.htmlpage rendering is broken becauseversions.htmlis not found. This results in a github 404 page being inserted into the page which breaks the formatting of the webpage.This PR changes the javascript function to insert an error message rather than the 404 page if the Snippet is not found.