Build docs on python3.5 with linkcheck running on python 2.7 #5797

Merged
merged 2 commits into from Jan 6, 2016

Conversation

Projects
None yet
4 participants
Owner

jenshnielsen commented Jan 5, 2016

This is an alternative to #5338 which runs the yet not python 3.5 compatible linkchecker on python 2.7 but builds the docs with python 3.5

mdboom and others added some commits Oct 28, 2015

@mdboom @jenshnielsen mdboom Build docs on Python 3.5 a984380
@jenshnielsen jenshnielsen Run linkchecker with python 2
5edf56f

@jenshnielsen jenshnielsen commented on the diff Jan 5, 2016

.travis.yml
@@ -86,8 +86,7 @@ install:
- |
if [[ $BUILD_DOCS == true ]]; then
- pip install $PRE numpydoc ipython jsonschema mistune colorspacious
- pip install -q $PRE linkchecker
+ pip install $PRE numpydoc ipython colorspacious
@jenshnielsen

jenshnielsen Jan 5, 2016

Owner

I have removed jsonshema and mistune they are not needed anymore. They were only there because ipython had a bud in its dependencies

Owner

mdboom commented Jan 5, 2016

In terms of catching bugs in and triggered by the examples, would it make sense to build the docs in both Py3 and Py2 (in separate Travis configs so they run in parallel)?

Owner

jenshnielsen commented Jan 5, 2016

I have thought about that and it probably would. It's of cause a tradeoff between the time spend on building the docs vs how much more coverage it gives. Perhaps we should only do that after #5597 is merged?

Owner

mdboom commented Jan 5, 2016

Waiting for #5597 probably makes sense -- not that that requires an IPython patch (merged, but not released) and either a new release of numpydoc or moving to sphinx-napoleon (#5743)

@tacaswell tacaswell added a commit that referenced this pull request Jan 6, 2016

@tacaswell tacaswell Merge pull request #5797 from jenshnielsen/build-docs-on-35-linkcheck
Build docs on python3.5 with linkcheck running on python 2.7
e035cf9

@tacaswell tacaswell merged commit e035cf9 into matplotlib:master Jan 6, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.574%
Details

tacaswell removed the needs_review label Jan 6, 2016

jenshnielsen deleted the jenshnielsen:build-docs-on-35-linkcheck branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment