Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Build docs on python3.5 with linkcheck running on python 2.7 #5797
+6
−4
Conversation
tacaswell
added the
needs_review
label
Jan 5, 2016
mdboom
and others
added some commits
Oct 28, 2015
jenshnielsen
commented on the diff
Jan 5, 2016
.travis.yml
| @@ -86,8 +86,7 @@ install: | ||
| - | | ||
| if [[ $BUILD_DOCS == true ]]; then | ||
| - pip install $PRE numpydoc ipython jsonschema mistune colorspacious | ||
| - pip install -q $PRE linkchecker | ||
| + pip install $PRE numpydoc ipython colorspacious |
jenshnielsen
Owner
|
|
In terms of catching bugs in and triggered by the examples, would it make sense to build the docs in both Py3 and Py2 (in separate Travis configs so they run in parallel)? |
|
I have thought about that and it probably would. It's of cause a tradeoff between the time spend on building the docs vs how much more coverage it gives. Perhaps we should only do that after #5597 is merged? |
tacaswell
added a commit
that referenced
this pull request
Jan 6, 2016
|
|
tacaswell |
e035cf9
|
tacaswell
merged commit e035cf9
into matplotlib:master
Jan 6, 2016
tacaswell
removed the
needs_review
label
Jan 6, 2016
QuLogic
added Documentation Testing
labels
Jan 6, 2016
QuLogic
added this to the
proposed next point release (2.1)
milestone
Jan 6, 2016
jenshnielsen
deleted the
jenshnielsen:build-docs-on-35-linkcheck branch
Jan 6, 2016
This was referenced Jan 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jenshnielsen commentedJan 5, 2016
This is an alternative to #5338 which runs the yet not python 3.5 compatible linkchecker on python 2.7 but builds the docs with python 3.5