Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix #5895: Properly clip MOVETO commands #5911
Conversation
mdboom
added the
needs_review
label
Jan 25, 2016
tacaswell
modified the milestone: Critical bug fix release (1.5.2)
Jan 25, 2016
|
Travis failed with lots of small differences. |
mdboom
added some commits
Jan 26, 2016
|
This is passing Travis now and ready for final review. |
This was referenced Jan 28, 2016
tacaswell
commented on the diff
Feb 2, 2016
| } | ||
| while ((code = m_source->vertex(x, y)) != agg::path_cmd_stop) { | ||
| - if (code == (agg::path_cmd_end_poly | agg::path_flags_close)) { | ||
| + switch (code) { | ||
| + case (agg::path_cmd_end_poly | agg::path_flags_close): |
tacaswell
Owner
|
tacaswell
commented on the diff
Feb 2, 2016
| m_moveto = true; | ||
| m_source->rewind(path_id); | ||
| } | ||
| + int draw_clipped_line(double x0, double y0, double x1, double y1) | ||
| + { | ||
| + unsigned moved = agg::clip_line_segment(&x0, &y0, &x1, &y1, m_cliprect); | ||
| + // moved >= 4 - Fully clipped | ||
| + // moved & 1 != 0 - First point has been moved | ||
| + // moved & 2 != 0 - Second point has been moved | ||
| + if (moved < 4) { | ||
| + if (moved & 1 || m_moveto) { | ||
| + queue_push(agg::path_cmd_move_to, x0, y0); |
tacaswell
Owner
|
tacaswell
added a commit
that referenced
this pull request
Feb 22, 2016
|
|
tacaswell |
6922209
|
tacaswell
merged commit 6922209
into matplotlib:master
Feb 22, 2016
tacaswell
removed the
needs_review
label
Feb 22, 2016
tacaswell
added a commit
that referenced
this pull request
Feb 22, 2016
|
|
tacaswell |
512c8d0
|
|
back ported as 512c8d0 |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
|
|
tacaswell |
6569980
|
mdboom commentedJan 25, 2016
I haven't run the tests on this yet... we'll see what Travis CI thinks.