/matplotlib

Make barbs draw correctly (Fixes #5803) #5914

Merged
merged 2 commits into from Jan 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
3 participants
@dopplershift @tacaswell @mdboom
@dopplershift
Contributor

dopplershift commented Jan 26, 2016

Fixes the linewidth problem (#5803) with Barbs. Also adds a simple test so that this shouldn't break silently next time.

dopplershift added some commits Jan 26, 2016

@dopplershift dopplershift Make barbs draw correctly again (Fixes #5803) 
Changes to default linewidth/outline for polygons caused barbs to not be
drawn, since they relied on the previous default linewidth of 1. Now we
pass a linewidth of 1 unless explicitly overridden.
 ec6910c
@dopplershift dopplershift Add a test for Barbs. 
This is based completely on one of the plots in barbs_demo.py, but it
does a pretty good job of exercising Barbs' features.

Some checks were not successful

1 errored and 1 successful checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
b8f0352

mdboom added the needs_review label Jan 26, 2016

tacaswell added this to the 2.0 (style change major release) milestone Jan 26, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jan 26, 2016

@tacaswell tacaswell Merge pull request #5914 from dopplershift/fix-barbs 
Make barbs draw correctly (Fixes #5803)
 f913aa4

@tacaswell tacaswell merged commit f913aa4 into matplotlib:master Jan 26, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Jan 26, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jan 26, 2016

@tacaswell tacaswell Merge pull request #5914 from dopplershift/fix-barbs 
Make barbs draw correctly (Fixes #5803)
Conflicts:
	lib/matplotlib/tests/test_quiver.py
	  white space vs new test
 180a21c
@tacaswell
Owner

tacaswell commented Jan 26, 2016

backported to v2.x as 180a21c

dopplershift deleted the dopplershift:fix-barbs branch Jan 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment