Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixes for Windows test failures on appveyor #5922
Conversation
mdboom
added the
needs_review
label
Jan 26, 2016
QuLogic
commented on the diff
Jan 26, 2016
| @@ -0,0 +1,88 @@ | ||
| +#!/usr/bin/env python |
QuLogic
Member
|
|
The image comparison tests for some the failures are IMO to sensitive, at least I can't see much of a difference in that images. The only "real" difference is the font_styles, which is simply empty (-> all text missing)? |
janschulz
added some commits
Jan 26, 2016
|
Current output in my local py35 test run:
|
|
Ok, here are the tests from appveyor (which fail the build now): TARGET_ARCH=x86, CONDA_PY=27
TARGET_ARCH=x64, CONDA_PY=27
TARGET_ARCH=x64, CONDA_PY=34
TARGET_ARCH=x64, CONDA_PY=35
|
|
The |
|
BTW, this seems to be out of sync:
|
Indeed it is. I'll open another PR for that. |
mdboom
referenced
this pull request
Jan 27, 2016
Merged
Update docstring to match kwarg default #5924
|
There is also #5647, which lists these two tests as well:
-> currently set to 0.03, set tolerance to 0.05 on windows -> done
This has a black diff, so up the tolerance on windows to 0.013 -> done
This looks actually interesting: it seems that only the middle figure in the last row is different (at least the 32bit, py2.7 which I looked at) -> also done...
Also looks black, but only on py27/x86...? -> done
-> done |
|
https://travis-ci.org/matplotlib/matplotlib/jobs/105255492
[I really hate that the image comparison tests do not show the line number but only the decorator code path :-(] [Edit: seems to be a fluke, at least the next travis build didn't see that error?] |
|
And locally I still have the problem with
|
|
I will open a new issue for my local test failure, that looks like the fallback font doesn't work on my system. [Edit: the problem was a stale font cache which prevent this test to find the fallback fonts... See #5929 for the story... Note to self: before writing issues, use a debugger...] |
janschulz
referenced
this pull request
Jan 27, 2016
Closed
Fallback font doesn't work on windows? #5929
|
Ok, the builds in my appveyor instance already build the two py2.7 versions of the tests and they are green: https://ci.appveyor.com/project/JanSchulz/matplotlib/build/1.0.135 |
|
Open question: should I remove the |
|
And it's green again (in my build) :-) |
tacaswell
added a commit
that referenced
this pull request
Feb 1, 2016
|
|
tacaswell |
bbe421a
|
tacaswell
merged commit bbe421a
into matplotlib:master
Feb 1, 2016
tacaswell
removed the
needs_review
label
Feb 1, 2016
|
@tacaswell @mdboom Should the tests for which I changed the tolerance be added to #5647? |
QuLogic
added this to the
2.1 (next point release)
milestone
Feb 1, 2016
|
@janschulz Yes it would be good to collect the information about non zero tolerance in #5647 |
|
@jenshnielsen ok, done directly in the first comment as additional Todos: #5647 |
janschulz commentedJan 26, 2016
Fixes the windows test errors as seen on appveyor and makes appveyor test failures into build failures.
Closes: #5748