Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
TST: add a test for tilde in tempfile for the PS backend #5958
Conversation
mdboom
added the
needs_review
label
Feb 2, 2016
janschulz
referenced
this pull request
Feb 2, 2016
Merged
fix for latex call on PS backend (Issue #5895) #5928
QuLogic
added this to the
1.5.2 (Critical bug fix release)
milestone
Feb 2, 2016
QuLogic
and 1 other
commented on an outdated diff
Feb 2, 2016
lib/matplotlib/tests/test_backend_ps.py
| @@ -134,6 +134,46 @@ def test_patheffects(): | ||
| fig.savefig(ps, format='ps') | ||
| +@cleanup | ||
| +@needs_tex | ||
| +@needs_ghostscript | ||
| +def test_tilde_in_tempfilename(): | ||
| + # Tilde ~ in the tempdir path (e.g. TMPDIR, TMP oder TEMP on windows | ||
| + # when the username is very long and windows uses a short name) breaks | ||
| + # latex before https://github.com/matplotlib/matplotlib/pull/5928 | ||
| + import tempfile | ||
| + import shutil | ||
| + import os | ||
| + import os.path | ||
| + | ||
| + dirpath = None |
janschulz
Contributor
|
tacaswell
added a commit
that referenced
this pull request
Feb 3, 2016
|
|
tacaswell |
1fa2697
|
tacaswell
merged commit 1fa2697
into matplotlib:master
Feb 3, 2016
tacaswell
removed the
needs_review
label
Feb 3, 2016
tacaswell
added a commit
that referenced
this pull request
Feb 3, 2016
|
|
tacaswell |
a25bcbf
|
|
backported to 1.5.x as a25bcbf |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
|
|
tacaswell |
1e5ff75
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
janschulz commentedFeb 2, 2016
The PS uses latex in some cases (usetex=True) and latex does not like to be called with dirnames with ~ in it (reserved char). The Fix for that was in #5928, this is just a testcase to test for the fix.