ENH: add kwarg normalization function to cbook #5975

Merged
merged 1 commit into from Feb 15, 2016

Conversation

Projects
None yet
4 participants
Owner

tacaswell commented Feb 8, 2016

This is the first step to centralizing the normalizing kwarg
handling.

@tacaswell tacaswell ENH: add kwarg normalization function to cbook
This is the first step to centralizing the normalizing kwarg
handling.
7131970
Owner

tacaswell commented Feb 8, 2016

This is pulled out of #5056 (it is the first commit on that PR) and should be merged first so that we can backport this to 1.5.x (or at least 2.0) as it will help with issues like #5974

Member

WeatherGod commented Feb 8, 2016

Do we want to try applying it to the existing normalization/validation logic for cyclers? Would be interesting to see how we can apply it fo the needed key-changing feature for existing cycler objects.

Owner

tacaswell commented Feb 15, 2016

Probably, but I would rather get this in and then start to use it in later PRs rather than holding this up.

@mdboom mdboom added a commit that referenced this pull request Feb 15, 2016

@mdboom mdboom Merge pull request #5975 from tacaswell/enh_kwarg_normalize
ENH: add kwarg normalization function to cbook
14294c9

@mdboom mdboom merged commit 14294c9 into matplotlib:master Feb 15, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell deleted the tacaswell:enh_kwarg_normalize branch Feb 15, 2016

mdboom removed the needs_review label Feb 15, 2016

@mdboom mdboom added a commit that referenced this pull request Feb 15, 2016

@mdboom mdboom Merge pull request #5975 from tacaswell/enh_kwarg_normalize
ENH: add kwarg normalization function to cbook
b17cc2c
Owner

mdboom commented Feb 15, 2016

Cherry-picked to 1.5.x as b17cc2c

Owner

efiring commented Feb 16, 2016

This is failing on 2.6:

 File "/home/travis/build/matplotlib/matplotlib/venv/lib/python2.6/site-packages/matplotlib-1.5.1+48.gc6c43cc-py2.6-linux-x86_64.egg/matplotlib/cbook.py", line 2635, in normalize_kwargs

    "are not in kwargs".format(fail_keys))

ValueError: zero length field name in format
Owner

tacaswell commented Feb 16, 2016

See #6007

@tacaswell tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 22, 2016

@mdboom @tacaswell mdboom + tacaswell Merge pull request #5975 from tacaswell/enh_kwarg_normalize
ENH: add kwarg normalization function to cbook
9947808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment