Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
FIX: do not short-cut all white-space strings #6005
Conversation
tacaswell
added the
needs_review
label
Feb 15, 2016
tacaswell
added this to the
1.5.2 (Critical bug fix release)
milestone
Feb 15, 2016
|
Odd test failure, only on 2.7: ImageComparisonFailure: images not close: /home/travis/build/matplotlib/matplotlib/result_images/test_collections/EventCollection_plot__set_lineoffset_svg.png vs. /home/travis/build/matplotlib/matplotlib/result_images/test_collections/EventCollection_plot__set_lineoffset-expected_svg.png (RMS 0.080) |
|
@efiring I could not reproduce locally and restarting the test seems to have fixed it. |
efiring
added a commit
that referenced
this pull request
Feb 17, 2016
|
|
efiring |
f2cccf8
|
efiring
merged commit f2cccf8
into matplotlib:master
Feb 17, 2016
efiring
removed the
needs_review
label
Feb 17, 2016
|
The intermittent failure happened on master again https://travis-ci.org/matplotlib/matplotlib/builds/109789572 |
tacaswell
deleted the
tacaswell:fix_empty_strings branch
Feb 17, 2016
|
Again, it is showing up only in svg and on 2.7. It's hard to see how it could be related to this change--or to anything else, for that matter. |
tacaswell commentedFeb 15, 2016
When drawing text, assume that all user input is valid input and do not
consider an all white space string to be equivalent to an empty string.
Closes #2698