/matplotlib

Mnt cleanup pylab setup #6013

Merged
merged 6 commits into from Feb 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
3 participants
@tacaswell @WeatherGod @mdboom
@tacaswell
Owner

tacaswell commented Feb 17, 2016

No description provided.

tacaswell added some commits Feb 17, 2016

@tacaswell tacaswell MNT/API: remove __all__ from backends.__init__.py 
This would be an API break, however at some point most of these
attributes were removed from the module so trying to bulk import would
raise an AttributeError.
 c38137a
@tacaswell tacaswell MNT: move backend lookup inside pylab_setup 
closes #5513
 b67ee9e
@tacaswell tacaswell MNT: remove unused import 
The comment says that this is used by IPython (circa 2008) however it's
use was removed from the IPython code base in

770734dc47d57cdebc365fcbcd313e76a22be89d
Author: Brian Granger <ellisonbg@gmail.com>  2009-07-21 15:28:37

which Precedes: rel-0.11 so no supported version of IPython still
has this code.
 d2c9e35
@tacaswell tacaswell MNT: move pylab_setup with rest of imports 
Now that the backend resolution is done in `pylab_setup` instead of
at module import time this does not need to be imported after the call
to _backend_selection.
 b0db83e
@tacaswell tacaswell MNT/DOC: add input to pylab_setup + docs 
 - add backend as an input (maybe useful?)
 - add numpydoc style docstring
 35b80cc
@tacaswell tacaswell STY: style cleanup

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
b3c4e0a

tacaswell added the needs_review label Feb 17, 2016

tacaswell added this to the 2.1 (next point release) milestone Feb 17, 2016

@WeatherGod WeatherGod commented on the diff Feb 17, 2016

View full changes
lib/matplotlib/backends/__init__.py
-__all__ = ['backend','show','draw_if_interactive',
- 'new_figure_manager', 'backend_version']
@WeatherGod

WeatherGod Feb 17, 2016

Member

why get rid of this?

@tacaswell

tacaswell Feb 17, 2016

Owner

Most of these things are no longer exist in the module so it would raise an AttributeError.
@tacaswell
Owner

tacaswell commented Feb 17, 2016

I left pretty through commit messages on all of these changes.
@WeatherGod
Member

WeatherGod commented Feb 17, 2016

Ah, indeed. Ok, this looks fine to me. I take it none of this is supposed to be backported?

@mdboom mdboom added a commit that referenced this pull request Feb 22, 2016

@mdboom mdboom Merge pull request #6013 from tacaswell/mnt_cleanup_pylab_setup 
Mnt cleanup pylab setup
 2b4e698

@mdboom mdboom merged commit 2b4e698 into matplotlib:master Feb 22, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label Feb 22, 2016

tacaswell deleted the tacaswell:mnt_cleanup_pylab_setup branch Feb 22, 2016

This was referenced Mar 2, 2016

Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment