/matplotlib

Make @cleanup *really* support generative tests. #6022

Merged
merged 1 commit into from Feb 18, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
4 participants
@anntzer @tacaswell @QuLogic @mdboom
@anntzer
Contributor

anntzer commented Feb 18, 2016

Generative tests were still not run after #5809. If f is defined as def f(): yield, isgeneratorfunction(f) == isgenerator(f()) == True.
@anntzer anntzer Make @cleanup *really* support generative tests.

Some checks were not successful

1 failing and 1 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
56ec0c6

mdboom added the needs_review label Feb 18, 2016

tacaswell closed this Feb 18, 2016

tacaswell reopened this Feb 18, 2016

@tacaswell tacaswell added needs_review and removed needs_review labels Feb 18, 2016

@tacaswell
Owner

tacaswell commented Feb 18, 2016

'power cycled' to re-trigger build against new master.

tacaswell added this to the 2.1 (next point release) milestone Feb 18, 2016

anntzer referenced this pull request Feb 18, 2016

Merged

Better choice of offset-text. #5785

@tacaswell tacaswell added a commit that referenced this pull request Feb 18, 2016

@tacaswell tacaswell Merge pull request #6022 from anntzer/cleanup-generative-tests-again 
Make @cleanup *really* support generative tests.
 236411c

@tacaswell tacaswell merged commit 236411c into matplotlib:master Feb 18, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tacaswell
Owner

tacaswell commented Feb 18, 2016

Merging as I do not think the close/open cycle restarts appveyor.

tacaswell removed the needs_review label Feb 18, 2016

@tacaswell
Owner

tacaswell commented Feb 18, 2016

Does this need to be backported to 2.x?
@QuLogic
Member

QuLogic commented Feb 18, 2016

#5809 is actually milestoned to be on 1.5.2, though I'm not seeing it.

anntzer deleted the anntzer:cleanup-generative-tests-again branch Feb 21, 2016

@QuLogic
Member

QuLogic commented Mar 26, 2016

This should be backported if we want to get #5785 into 2.x, no?

@tacaswell tacaswell added a commit that referenced this pull request Mar 26, 2016

@tacaswell tacaswell Merge pull request #6022 from anntzer/cleanup-generative-tests-again 
Make @cleanup *really* support generative tests.
 80be853

@tacaswell tacaswell modified the milestone: 2.0 (style change major release), 2.1 (next point release) Mar 26, 2016

@tacaswell
Owner

tacaswell commented Mar 26, 2016

backported to v2.x as 0375ea4

@QuLogic Good catch on this

@bearstrong bearstrong added a commit to bearstrong/matplotlib that referenced this pull request Apr 1, 2016

@tacaswell @bearstrong tacaswell + bearstrong Merge pull request #6022 from anntzer/cleanup-generative-tests-again 
Make @cleanup *really* support generative tests.
 bdaefb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment