bug fix related #5479

[ryanbelt]

Table: auto_set_column_width not working #5479

As before, it append the whole parameter(col) into the _autoColumns even col is a list object.
at table.py line 490 inside function _update_position

for col in self._autoColumns:
      self._auto_set_column_width(col, renderer)

_auto_set_column_width are not able to manipulate with the index number as list rather then int passed from line490.

So, I decide to append number to _autoColumns as usual if and only if the parameter is integer. If it is a list, we will append each integer inside the parameter into _autoColumns

[tacaswell]

This is probably better to do as

try:
    self._autoColumns.extend(cell)
except CORRECT_EXCEPTION:
    self._autoColumns.append(col)

[ryanbelt]

I have change the format from type checking to exception checking.
This would allow not only list obj as the parameter, but also any kinds of iterable object such tuple etc.

table.auto_set_column_width(-1) # Default input
table.auto_set_column_width([-1,0,1]) # List input
table.auto_set_column_width((-1,0,1)) # Tuple input

[tacaswell]

This indentation is funny and you can use extend.

[ryanbelt]

I have just seen the comment from #6059. I am going to add the specific test case for this PR.

[ryanbelt]

@tacaswell ,
Test case for this specific bug has been added. Bascially testing every single column be able to auto_width. By using List, Tuple and single integer as input. I think those are the main issue on this bug.
Thank you

[dashed]

Strings are also iterable. Should that be also supported?

[ryanbelt]

@dashed , inside the _auto_set_column_width. if the object inside the _autoColumns is not an integer(index), It will not able to do the width adjustment and remain as default width (will causing content go out the box). So, it will not crash the program. It just skip all those string object until next integer found or stop at the end of the _autoColumns.

[dashed]

@ryanbelt Ah ok. Then should there be a test case for the behaviour you've just described?

[ryanbelt]

@dashed , thank you for the tips. Unexpected test case for iterable input as string has been added for this bug.

[dashed]

This might be worded in another way. Suggestion:

If col is iterable, concatenate to self._autoColumns. Otherwise, append it to self._autoColumns.

[dashed]

@ryanbelt Awesome. 👍 Unfortunately you beat us to the punch on this PR for d01. But I'll throw some suggestions your way for this PR 😄 .

[tacaswell]

Thanks!

Would one of you @dashed or @ryanbelt be willing to write a docstring for auto_set_column_width?

[dashed]

I'll leave that for @ryanbelt 😄

[ryanbelt]

        """Given column indexs in either List, Tuple or int. Will be able to
        autonatically set the columns into optimal sizes.
        """

@tacaswell ,
How should I added into the table.py since this pull request is closed?
Thank you.

[tacaswell]

@ryanbelt Make a new pull request. They are (more-or-less) free and the smaller the change, the easier it is to review.

Could you also explain the meaning of the values that are expected to be passed in?