Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Bring back the module level 'backend' #6095
Conversation
mdboom
added the
needs_review
label
Mar 2, 2016
|
It is not entirely clear to me how to keep the module level |
tacaswell
commented on the diff
Mar 2, 2016
| ''' | ||
| # Import the requested backend into a generic module object | ||
| - if backend is None: | ||
| - backend = matplotlib.get_backend() # validates, to match all_backends |
tacaswell
Owner
|
tacaswell
commented on the diff
Mar 2, 2016
| ''' | ||
| # Import the requested backend into a generic module object | ||
| - if backend is None: | ||
| - backend = matplotlib.get_backend() # validates, to match all_backends | ||
| - | ||
| - if backend.startswith('module://'): | ||
| - backend_name = backend[9:] | ||
| + if name is None: |
tacaswell
Owner
|
tacaswell
added this to the
2.1 (next point release)
milestone
Mar 2, 2016
|
Someone who is not me should look at this before it gets merged. |
mdboom
added a commit
that referenced
this pull request
Mar 7, 2016
|
|
mdboom |
0d1422b
|
ericdill commentedMar 2, 2016
The removal of the module level 'backend' broke ipython's pylab code. @tacaswell can you have a look? Renamed the
pylab_setup()kwarg toname, so thatbackendcould be a global in this function.Closes #6092