/matplotlib

Fix #6069. Handle image masks correctly #6099

Merged
merged 2 commits into from Mar 4, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
2 participants
@mdboom @tacaswell
@mdboom
Owner

mdboom commented Mar 2, 2016

Alternative to #6070

This works by converting the greyscale image to an RGBA image (with the
alpha channel created correctly) prior to resizing in Agg. This also
removes the hack (that caused problems with over/under) where we were
using negative values to indicate transparency.
@mdboom mdboom Fix #6069. Handle image masks correctly 
Alternative to #6070

This works by converting the greyscale image to an RGBA image (with the
alpha channel created correctly) prior to resizing in Agg.  This also
removes the hack (that caused problems with over/under) where we were
using negative values to indicate transparency.

Some checks were not successful

1 failing and 1 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
eda0912

mdboom added this to the 2.0 (style change major release) milestone Mar 2, 2016

mdboom added the needs_review label Mar 2, 2016

@mdboom mdboom Fix image_masked.py example

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
1204436
@mdboom
Owner

mdboom commented Mar 2, 2016

Passing Travis. Appveyor seems stuck in the queue.

@tacaswell tacaswell added a commit that referenced this pull request Mar 4, 2016

@tacaswell tacaswell Merge pull request #6099 from mdboom/masked-image 
Fix #6069.  Handle image masks correctly
 5c5a287

@tacaswell tacaswell merged commit 5c5a287 into matplotlib:master Mar 4, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Mar 4, 2016

@tacaswell tacaswell added a commit that referenced this pull request Mar 4, 2016

@tacaswell tacaswell Merge pull request #6099 from mdboom/masked-image 
Fix #6069.  Handle image masks correctly
 1302606
@tacaswell
Owner

tacaswell commented Mar 4, 2016

backported to v2.x as 1302606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment