/matplotlib

BUG: Allowing unknown drawstyles #6145

Merged
merged 1 commit into from Mar 13, 2016
+27 −0

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
4 participants
@madphysicist @tacaswell @mdboom @QuLogic
@madphysicist
Contributor

madphysicist commented Mar 11, 2016

Fixes #6143. Added test as well.

mdboom added the needs_review label Mar 11, 2016

@madphysicist @madphysicist madphysicist BUG: Allowing unknown drawstyles. Fixes #6143. 
Added a check that forbids `drawstyle` keywords that are not listed in the documentation.
Added tests to mimic linestyle tests.
Added self to mailmap.

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
9265aa0
@madphysicist
Contributor

madphysicist commented Mar 12, 2016

@tacaswell Looks like its working now.

@tacaswell tacaswell added a commit that referenced this pull request Mar 13, 2016

@tacaswell tacaswell Merge pull request #6145 from madphysicist/patch-1 
MNT: fail earlier on unknown draw_style
 6a57084

@tacaswell tacaswell merged commit 6a57084 into matplotlib:master Mar 13, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Mar 13, 2016

QuLogic added this to the 2.1 (next point release) milestone Mar 13, 2016

@tacaswell tacaswell added a commit that referenced this pull request Mar 13, 2016

@tacaswell tacaswell Merge pull request #6145 from madphysicist/patch-1 
MNT: fail earlier on unknown draw_style

Conflicts:
	.mailmap
 e738593
@tacaswell
Owner

tacaswell commented Mar 13, 2016

Backported to v2.x as e738593
@tacaswell
Owner

tacaswell commented Mar 13, 2016

@madphysicist Thanks!

@tacaswell tacaswell modified the milestone: 2.0 (style change major release), 2.1 (next point release) Mar 13, 2016

madphysicist deleted the madphysicist:patch-1 branch Mar 13, 2016

@madphysicist
Contributor

madphysicist commented Mar 14, 2016

No problem. Is there a release notes or something like that I should update?
@tacaswell
Owner

tacaswell commented Mar 14, 2016

We maintain a whats_new for new features and an api_changes for api breaking changes. This does not really fall into either category.

Looking into this a bit more, this might have caused a minor regression which is it used to be possible to set the drawstyle to None (which is the default value). That should probably be restored.

madphysicist restored the madphysicist:patch-1 branch Mar 14, 2016

madphysicist referenced this pull request Mar 14, 2016

Merged

Bug: Fixed regression of `drawstyle=None` #6156

@madphysicist
Contributor

madphysicist commented Mar 14, 2016

Fixed that here: #6156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment