/matplotlib

Issue #6105: Adds targetfig parameter to the subplot2grid function #6179

Merged
merged 3 commits into from Mar 20, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
3 participants
@paulkirow @tacaswell @mdboom
@paulkirow
Contributor

paulkirow commented Mar 17, 2016

As mentioned in issue #6105. A simple implementation. I named the argument targetfig to be consistent with another function in pyplot, subplot_tool.

Feedback needed.
@paulkirow paulkirow Adds targetfig parameter to the subplot2grid function 
As mentioned in issue #6105

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
c16aa8c

mdboom added the needs_review label Mar 17, 2016

@tacaswell tacaswell commented on an outdated diff Mar 18, 2016

View full outdated diff
lib/matplotlib/pyplot.py
@@ -1147,7 +1147,7 @@ def subplots(nrows=1, ncols=1, sharex=False, sharey=False, squeeze=True,
return fig, axs
-def subplot2grid(shape, loc, rowspan=1, colspan=1, **kwargs):
+def subplot2grid(shape, loc, rowspan=1, colspan=1, targetfig=None, **kwargs):
@tacaswell

tacaswell Mar 18, 2016

Owner

Just call it fig.

tacaswell added this to the 2.1 (next point release) milestone Mar 18, 2016

@paulkirow paulkirow Renamed parameter and removed redundancy

Some checks were not successful

1 failing and 1 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
ec54580
@tacaswell
Owner

tacaswell commented Mar 19, 2016

👍 Just needs documentation in both whats_new and the docstring.
@paulkirow paulkirow Updated docstring and created whats_new document 
These changes are meant to document the added parameter to the subplot2grid method

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
9466318

@tacaswell tacaswell added a commit that referenced this pull request Mar 20, 2016

@tacaswell tacaswell Merge pull request #6179 from paulkirow/d01f1 
ENH: Adds targetfig parameter to the subplot2grid function

closes #6105:
 0003470

@tacaswell tacaswell merged commit 0003470 into matplotlib:master Mar 20, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Mar 20, 2016

This was referenced Apr 23, 2016

Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment