MNT: use stdlib tools in allow_rasterization #6232

Merged
merged 1 commit into from Mar 28, 2016

Conversation

Projects
None yet
3 participants
Owner

tacaswell commented Mar 27, 2016

Use a context manager to mange enabling/disabling the rasterization.
This will now try to un-wrap the rasterization context state if an
exception occurs.

Use functools.wraps instead of doing it 'manually'.

@tacaswell tacaswell MNT: use stdlib tools in allow_rasterization
Use a context manager to mange enabling/disabling the rasterization.
This will now try to un-wrap the rasterization context state if an
exception occurs.

Use functools.wraps instead of doing it 'manually'.
382fe96

tacaswell added this to the 2.1 (next point release) milestone Mar 27, 2016

Member

WeatherGod commented Mar 28, 2016

This looks good to me. Are there any back-compat concerns removing those methods? We could still keep them around in case other projects are using them.

Owner

tacaswell commented Mar 28, 2016

Those functions are local to the decorator def.

Member

WeatherGod commented Mar 28, 2016

Ah, right! Ok. Merging.

@WeatherGod WeatherGod merged commit eac6ce1 into matplotlib:master Mar 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label Mar 28, 2016

tacaswell deleted the tacaswell:mnt_raster_context branch Mar 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment