/matplotlib

Adjust test tolerance to pass for me on OSX #6249

Merged
merged 4 commits into from Apr 7, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
3 participants
@jenshnielsen @mdboom @QuLogic
@jenshnielsen
Owner

jenshnielsen commented Mar 30, 2016

These are mainly the same as changed on windows. Rather than making more OS specific hacks I have changed them everywhere but I could be convinced otherwise.
None of the changes are related to text/freetype as far as I can see but more likely to be related to floating point math and thus libraries, OS, compilers, CPU architecture ...

Might want to backport to 2.x

mdboom added the needs_review label Mar 30, 2016

@mdboom
Owner

mdboom commented Mar 30, 2016

👍 from me. And I'm fine with removing the windows-specific settings.

@QuLogic QuLogic commented on the diff Mar 30, 2016

View full changes
lib/matplotlib/tests/test_axes.py
@@ -2763,7 +2763,7 @@ def test_subplot_key_hash():
@image_comparison(baseline_images=['specgram_freqs',
'specgram_freqs_linear'],
remove_text=True, extensions=['png'],
- tol=0.07 if on_win else 0.03)
@QuLogic

QuLogic Mar 30, 2016

Member

Can you also remove on_win and the sys import as well?

@jenshnielsen

jenshnielsen Apr 2, 2016

Owner

done

jenshnielsen added some commits Feb 16, 2016

@jenshnielsen jenshnielsen Adjust tol in patheffects tests to pass on my mac OSX10.11 homebrew p… 
…ython
 9c36bfd
@jenshnielsen jenshnielsen adjust tol in test trisurf3d to pass on my mac f4ff4c8
@jenshnielsen jenshnielsen Adjust tol in test_axes:sepcgram to pass on my mac 32f8c0f
@jenshnielsen jenshnielsen Remove unused on_win

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
598dce8

@mdboom mdboom merged commit 3b2ab9d into matplotlib:master Apr 7, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label Apr 7, 2016

@mdboom mdboom added a commit that referenced this pull request Apr 7, 2016

@mdboom mdboom Merge pull request #6249 from jenshnielsen/adjusttolosx2 
Adjust test tolerance to pass for me on OSX
 9a74cd7
@mdboom
Owner

mdboom commented Apr 7, 2016

Cherry-picked to v2.x as 9a74cd7

QuLogic added this to the 2.0 (style change major release) milestone Apr 7, 2016

jenshnielsen deleted the jenshnielsen:adjusttolosx2 branch Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment