Bug fix and general touch ups for hist3d_demo example (#1702) #6260

Merged
merged 2 commits into from Apr 2, 2016

Conversation

Projects
None yet
5 participants
Contributor

TrishGillett commented Apr 2, 2016

  • Fixes bug #1702 by using 'F' when flattening xpos, ypos
  • Makes the bin ranges fixed, also as discussed on #1702
  • Adds a docstring (as per MEP12) plus some clarifying comments

TrishGillett added some commits Mar 16, 2016

@TrishGillett TrishGillett Issue #1702 transpose bugfix 9b9ed32
@TrishGillett TrishGillett Fix bin range and tidy up comments.
4340a91

mdboom added the needs_review label Apr 2, 2016

Contributor

TrishGillett commented Apr 2, 2016

I can see that the build has failed, but I've looked at the logs and I'm not sure how the failures are actually related to my changes. I'd appreciate some help understanding this. Thanks in advance!

Owner

jenshnielsen commented Apr 2, 2016

The failure on Travis is intermittent and not related to your changes. I have restarted the particular test. I suspect the same is the case on appveyor

Owner

jenshnielsen commented Apr 2, 2016

Appveyor is failing due to #5950 since conda have switched to Numpy 1.11

Contributor

TrishGillett commented Apr 2, 2016

Okay, great, thanks! I see Travis passed this time. :)

@tacaswell tacaswell merged commit 715435c into matplotlib:master Apr 2, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Apr 2, 2016

Owner

tacaswell commented Apr 2, 2016

Thanks!

I believe this is your first mpl contribution, congrats and hopefully we will see you again 😄

Contributor

TrishGillett commented Apr 2, 2016

Thanks! I've been looking for something approachable to contribute to, and now that I've discovered MEP12 I'm thinking of sticking around here and working on cleaning up some of the other examples. 😊

Owner

tacaswell commented Apr 2, 2016

Great! Good documentation is very important and an area where mpl could definitely be doing much better. Any work on the examples is very appreciated.

@tacaswell tacaswell added a commit that referenced this pull request Apr 2, 2016

@tacaswell tacaswell Merge pull request #6260 from discardthree/bug-docs-1702
Bug fix and general touch ups for hist3d_demo example

closes #1702
a8851dd
Owner

tacaswell commented Apr 2, 2016

backported to v1.5.x as a8851dd

QuLogic added the mplot3d label Apr 2, 2016

@tacaswell tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 22, 2016

@tacaswell tacaswell Merge pull request #6260 from discardthree/bug-docs-1702
Bug fix and general touch ups for hist3d_demo example

closes #1702
44f02b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment