Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Bug fix and general touch ups for hist3d_demo example (#1702) #6260
Conversation
TrishGillett
added some commits
Mar 16, 2016
mdboom
added the
needs_review
label
Apr 2, 2016
|
I can see that the build has failed, but I've looked at the logs and I'm not sure how the failures are actually related to my changes. I'd appreciate some help understanding this. Thanks in advance! |
|
The failure on Travis is intermittent and not related to your changes. I have restarted the particular test. I suspect the same is the case on appveyor |
|
Appveyor is failing due to #5950 since conda have switched to Numpy 1.11 |
|
Okay, great, thanks! I see Travis passed this time. :) |
tacaswell
merged commit 715435c
into matplotlib:master
Apr 2, 2016
tacaswell
removed the
needs_review
label
Apr 2, 2016
|
Thanks! I believe this is your first mpl contribution, congrats and hopefully we will see you again |
|
Thanks! I've been looking for something approachable to contribute to, and now that I've discovered MEP12 I'm thinking of sticking around here and working on cleaning up some of the other examples. |
|
Great! Good documentation is very important and an area where mpl could definitely be doing much better. Any work on the examples is very appreciated. |
tacaswell
added a commit
that referenced
this pull request
Apr 2, 2016
|
|
tacaswell |
a8851dd
|
|
backported to v1.5.x as a8851dd |
QuLogic
added this to the
1.5.2 (Critical bug fix release)
milestone
Apr 2, 2016
QuLogic
added the
mplot3d
label
Apr 2, 2016
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
|
|
tacaswell |
44f02b0
|
TrishGillett commentedApr 2, 2016